Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow device names newer than 2014 (viewportsizes.com) #3767

Closed
JoshuaKGoldberg opened this issue May 2, 2019 · 6 comments
Closed

Allow device names newer than 2014 (viewportsizes.com) #3767

JoshuaKGoldberg opened this issue May 2, 2019 · 6 comments
Assignees
Labels
AREA: server HELP WANTED STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: browser natives TYPE: enhancement The accepted proposal for future implementation.
Milestone

Comments

@JoshuaKGoldberg
Copy link

Are you requesting a feature or reporting a bug?

Reporting a bug

What is your Test Scenario?

I'd like to test at resolutions of devices such as the Pixel series and newer iPhones.

What is the Current behavior?

http://viewportsizes.com only has devices up through 2014's iPhone 6.

What is the Expected behavior?

...more new than that?

How would you reproduce the current behavior (if this is a bug)?

https://devexpress.github.io/testcafe/documentation/test-api/actions/resize-window.html#fitting-the-window-into-a-particular-device

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label May 2, 2019
@AndreyBelym AndreyBelym self-assigned this May 6, 2019
@AndreyBelym AndreyBelym added AREA: server SYSTEM: browser natives TYPE: enhancement The accepted proposal for future implementation. labels May 6, 2019
@AndreyBelym
Copy link
Contributor

Thank you for your inquiry. I agree that the device list from http://viewportsizes.com is outdated and incomplete. The website owner doesn't support it anymore. It means that we need to find a different database that can be used as a source of device metrics. Do you have any suggestions on websites or APIs that can provide such information?

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label May 6, 2019
@JoshuaKGoldberg
Copy link
Author

https://en.wikipedia.org/wiki/Comparison_of_high-definition_smartphone_displays is pretty complete, if that helps. I just Googled around till I found it 😉.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Aug 13, 2019
@devmondo
Copy link

I see that the http://viewportsizes.com/ is gone already! so it might be a good idea to update the docs?

this library is outdated, but it might help as base https://www.npmjs.com/package/viewport-list

hope that helps :)

@helen-dikareva
Copy link
Collaborator

Thank you for drawing our attention to this. Seems like the time to change the source of device resolutions has definitely come. I'll add this issue to the Planned milestone.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Aug 14, 2019
@helen-dikareva helen-dikareva removed their assignment Aug 14, 2019
@helen-dikareva helen-dikareva added this to the Planned milestone Aug 14, 2019
@JoshuaKGoldberg
Copy link
Author

FWIW, this exists in https://github.com/DevExpress/testcafe-browser-tools/blob/master/data/devices.json.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Aug 14, 2019
@helen-dikareva helen-dikareva removed the STATE: Need response An issue that requires a response or attention from the team. label Aug 14, 2019
@AndreyBelym AndreyBelym modified the milestones: Planned, Sprint #48 Dec 25, 2019
@AndreyBelym AndreyBelym modified the milestones: Sprint #48, Sprint #49 Jan 10, 2020
@AlexKamaev AlexKamaev self-assigned this Jan 14, 2020
@AndreyBelym AndreyBelym modified the milestones: Sprint #49, Sprint #50 Jan 27, 2020
@lock
Copy link

lock bot commented Feb 17, 2020

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Feb 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AREA: server HELP WANTED STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: browser natives TYPE: enhancement The accepted proposal for future implementation.
Projects
None yet
Development

No branches or pull requests

5 participants