Kraken timeouts and error handling bug

[kareha]

System information

• Have I written custom code (as opposed to using zenbot vanilla): no
• OS Platform and Distribution (e.g., Linux Ubuntu 16.04): linux
• Zenbot version (commit ref, or version): 4.10 latest
• Zenbot branch: master
• NodeJS version: latest
• Python version (when using a python script): latest
• Exact command to reproduce (include everything): zenbot trade kraken.XXBT-ZEUR
• Did I make any changes to conf-sample.js?: no

Describe the problem

Kraken api often times out.
Kraken getTrades errors are not passed to callback, leads to "Download Complete" if its not. (see code below)
Kraken trade error handling, leads to trades, without getting order id? Needs to be checked further.

Source code / Error logs

Add Kraken timeout:
Change Line 21 to:
public_client = new KrakenClient('', '', { timeout: 30000 })

Change Line 31 to:
authed_client = new KrakenClient(conf.kraken.key, conf.kraken.secret, { timeout: 30000 })

Kraken Error handling:
Change Line 119 to:
return cb(error)

Unsure, but Add to Line 294:
return cb(null, order)
Also within the block from Line 278 to 295: Missing error handling if error but none of the error condition matches?

[Scre13]

@kareha solution solves the Kraken timeout issue, but from 15-30 minutes a new warnung is shown:
"Kraken API warning - unable to call getBalance (Error: API:Invalid nonce), retrying in 0.5s"

[diegstroyer]

Looks that your code solves the issue, thanks @kareha