Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis CI file #60

Closed
kukreja-vikramaditya opened this issue Apr 11, 2017 · 11 comments
Closed

Update Travis CI file #60

kukreja-vikramaditya opened this issue Apr 11, 2017 · 11 comments

Comments

@kukreja-vikramaditya
Copy link
Contributor

Need to fix travis ci file

@hardik124
Copy link
Contributor

What is the problem with Travis CI file ?

@kukreja-vikramaditya
Copy link
Contributor Author

CI tests are failing at Travis. Please investigate the failures and find solution for the same

@hardik124
Copy link
Contributor

@kukreja-vikramaditya do we necessarily need to build using jdk-7 as well ?
build with jdk-8 works fine after fixing the issues with permission , but 7 doesnt .

@kukreja-vikramaditya
Copy link
Contributor Author

@hardik124 Yes do not remove jdk7. Fix issues for both 7 and 8. Check this sample .travis.yml http://pastebin.ubuntu.com/24388468/ . See the before_script and scripts section. The app should be run on the created emulator and be able to run the ./gradlew commands

@hardik124
Copy link
Contributor

@kukreja-vikramaditya , build tools 25 requires jdk8 . Hence I dont think it will work with jdk 7 , or we have to downgrade our build tools .
What do you think is the possible solutions ?

@kukreja-vikramaditya
Copy link
Contributor Author

build tools 25 requires jdk8 . Hence I dont think it will work with jdk 7

Please post the link from you are stating this.

@hardik124
Copy link
Contributor

Although official Android release docs don't mention any Java version restrictions. I have encountered this issue when I tried to use jdk 8.
Here are more such queries.

http://stackoverflow.com/questions/39116095/android-studio-buildtools-24-0-1-requires-java-1-8-or-above

https://teamtreehouse.com/community/getting-this-message-buildtools-2401-requires-java-18-or-above-current-jdk-version-is-16.

@kukreja-vikramaditya
Copy link
Contributor Author

For openjdk7, it turns out that the dependencies in DoJMA app cannot be compiled for openjdk versions lesser than 52(8) but since travis doesn't support openjdk8, it is best that we continue with oraclejdk8.

Please resolve other issues of the file so that CIs are green.

@hardik124
Copy link
Contributor

If i remove jdk7 , it works fine . Should i send a PR?

@kukreja-vikramaditya
Copy link
Contributor Author

Yes send PR with remaining fixes as mentioned here

See the before_script and scripts section. The app should be run on the created emulator and be able to run the ./gradlew commands

@kukreja-vikramaditya
Copy link
Contributor Author

Issue is resolved.
@hardik124 Please create new issue regarding LeakCanary failures ate discussed in #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants