Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send values during sensor error and warm up #8

Closed
khskekec opened this issue Nov 5, 2022 · 4 comments
Closed

Do not send values during sensor error and warm up #8

khskekec opened this issue Nov 5, 2022 · 4 comments
Assignees

Comments

@khskekec
Copy link
Contributor

khskekec commented Nov 5, 2022

Actually the broadcast is triggered during sensor errors and also in the warm up phase. This might lead to wrong decisions in AAPS due to wrong values.

The broadcasting should only happen if the sensor is in a valid state.

@khskekec khskekec changed the title Do no send values during sensor error and warm up Do not send values during sensor error and warm up Nov 5, 2022
@khskekec khskekec self-assigned this Nov 12, 2022
@blaqone
Copy link
Collaborator

blaqone commented Jan 7, 2023

Found the same
Uploading 13733C64-0EA3-494E-AC3E-D4C452EB7EF7.jpeg…

@khskekec
Copy link
Contributor Author

khskekec commented Feb 8, 2023

Hi @mxsrm,

We started to debug this issue and hopefully will come to a solution very fast.

I will keeping you informed.

@CaptainBalou
Copy link

Ideally the new sensor values get somehow matched to the old ones to don't get recalculation errors in AAPS because the reading minutes are different. Maybe during the first 8 readings the time could be moved to the real one. Don't know if AAPS can be tricked so easy. 😉

@khskekec
Copy link
Contributor Author

So far there were no problematic values during sensor error or warmup phase for us especially. Therefore I will close this issue and would address it if it comes up again from someone else.

Kind regards

Selçuk

@khskekec khskekec closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants