Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Any type on _convert_type #437

Open
DominicOram opened this issue Apr 26, 2024 · 2 comments
Open

Remove Any type on _convert_type #437

DominicOram opened this issue Apr 26, 2024 · 2 comments
Labels
python Pull requests that update Python code
Milestone
1.0.0

Comments

@DominicOram
Copy link
Contributor

Once python/mypy#9773 we can remove the | Any in _convert_type.

Acceptance Criteria

  • Any type hint removed here
  • Type checkers and unit tests still happy
@DominicOram DominicOram mentioned this issue Apr 26, 2024
Merged
@stan-dot stan-dot added this to the 1.0.0 milestone May 16, 2024
@stan-dot stan-dot added the python Pull requests that update Python code label Sep 9, 2024
@stan-dot
Copy link
Contributor

stan-dot commented Sep 9, 2024

@callumforrester have we moved away from mypy to pyright enough that we can remove | Any without waiting for that mypy issue?

At the moment it does seem that we use mypy in the project

@callumforrester
Copy link
Contributor

Pending #619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Pull requests that update Python code
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@DominicOram @callumforrester @stan-dot