You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I note that a lot of effort has gone into making dodal compatible with both versions of ophyd. I think it's worth having the discussion of whether there is any restructuring that can be done to dodal, ophyd v2 or both to make the interoperability easier.
For example, ophyd v2 automatically names devices and does not generally pass device names in their constructors. Dodal tends to take a name in its factory functions and pass it on to the device constructor.
From discussions with @coretl
Ophyd v2 does already take name in the constructor by convention. We should stick to that convention. We shouldn't tie ourselves to the context manager, maybe implement something similar in dodal that works for v1 and v2 devices?
As alluded to in #153...
I note that a lot of effort has gone into making dodal compatible with both versions of ophyd. I think it's worth having the discussion of whether there is any restructuring that can be done to dodal, ophyd v2 or both to make the interoperability easier.
For example, ophyd v2 automatically names devices and does not generally pass device names in their constructors. Dodal tends to take a name in its factory functions and pass it on to the device constructor.
It's important that we have these discussions to avoid siloing and conway effects so paging
@DominicOram @dperl-dls @DiamondJoseph @RAYemelyanova @evalott100 @coretl
The text was updated successfully, but these errors were encountered: