Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ophyd v1 and v2 compatibility #154

Closed
callumforrester opened this issue Aug 25, 2023 · 2 comments
Closed

Ophyd v1 and v2 compatibility #154

callumforrester opened this issue Aug 25, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@callumforrester
Copy link
Contributor

As alluded to in #153...

I note that a lot of effort has gone into making dodal compatible with both versions of ophyd. I think it's worth having the discussion of whether there is any restructuring that can be done to dodal, ophyd v2 or both to make the interoperability easier.

For example, ophyd v2 automatically names devices and does not generally pass device names in their constructors. Dodal tends to take a name in its factory functions and pass it on to the device constructor.

It's important that we have these discussions to avoid siloing and conway effects so paging
@DominicOram @dperl-dls @DiamondJoseph @RAYemelyanova @evalott100 @coretl

@callumforrester callumforrester added the enhancement New feature or request label Aug 25, 2023
@callumforrester
Copy link
Contributor Author

From discussions with @coretl
Ophyd v2 does already take name in the constructor by convention. We should stick to that convention. We shouldn't tie ourselves to the context manager, maybe implement something similar in dodal that works for v1 and v2 devices?

@callumforrester
Copy link
Contributor Author

Decision here is to migrate to Ophyd v2, now called ophyd-async, continued in #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant