Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove thumbnail writing #655

Closed
DominicOram opened this issue Jun 28, 2024 · 2 comments · Fixed by DiamondLightSource/hyperion#1487
Closed

Remove thumbnail writing #655

DominicOram opened this issue Jun 28, 2024 · 2 comments · Fixed by DiamondLightSource/hyperion#1487
Assignees
@rtuck99
Labels
needed_for_release Issues that must be complete before the next release

Comments

@DominicOram
Copy link
Contributor

Following https://jira.diamond.ac.uk/browse/LIMS-1134 we no longer need to write out thumbnail images, we should remove this code.

Acceptance Criteria

  • Thumbnail writing is removed
@DominicOram DominicOram moved this to Candidates for Next Sprint in Hyperion Jun 28, 2024
@DominicOram DominicOram moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion Jul 9, 2024
@DominicOram
Copy link
Contributor Author

From DiamondLightSource/hyperion#1465 (comment) this is actually causing issues in hyperion so bumping it's prioirity

@DominicOram DominicOram added the needed_for_release Issues that must be complete before the next release label Jul 12, 2024
@d-perl
Copy link
Contributor

d-perl commented Jul 15, 2024

we think XS

@DominicOram DominicOram mentioned this issue Jul 16, 2024
Closed
@rtuck99 rtuck99 self-assigned this Jul 16, 2024
@rtuck99 rtuck99 moved this from Todo This Sprint to In Progress in Hyperion Jul 16, 2024
@rtuck99 rtuck99 mentioned this issue Jul 16, 2024
Merged
@rtuck99 rtuck99 moved this from In Progress to Review in Hyperion Jul 16, 2024
@rtuck99 rtuck99 mentioned this issue Jul 16, 2024
Merged
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Jul 17, 2024
@DominicOram DominicOram removed this from Hyperion Jul 29, 2024
@DominicOram DominicOram mentioned this issue Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtuck99 rtuck99

Labels
needed_for_release Issues that must be complete before the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert unit test fix relating to now-reverted dodal thumbnail generation DiamondLightSource/hyperion
3 participants
@rtuck99 @DominicOram @d-perl