Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Remove now obsolete references to transmission_fraction and flux #1295

Closed
rtuck99 opened this issue Apr 8, 2024 · 1 comment
Closed

Remove now obsolete references to transmission_fraction and flux #1295

rtuck99 opened this issue Apr 8, 2024 · 1 comment

Comments

@rtuck99
Copy link
Contributor

rtuck99 commented Apr 8, 2024 •
edited
Loading

Since the integration of PRs to fix #1733 and #1033 we can now remove the code referenced by the corresponding TODOs and also remove the ispyb_params fields

#1033 current energy covered by #1292
@DominicOram DominicOram moved this to Backlog in Hyperion Apr 8, 2024
@rtuck99 rtuck99 mentioned this issue Apr 8, 2024
Merged
@rtuck99 rtuck99 changed the title Remove now obsolete references to transmission_fraction and current_energy_ev Remove now obsolete references to transmission_fraction and flux Apr 8, 2024
@DominicOram
Copy link
Collaborator

Sorry, my bad for making awkward half issues. This makes sense to do as one with #1292 so putting it all in there.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Hyperion Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtuck99 @DominicOram