Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mass tweaks/minor fixes #447

Closed
12 of 13 tasks
blondejamtart opened this issue Jan 17, 2019 · 1 comment · Fixed by #452
Closed
12 of 13 tasks

Mass tweaks/minor fixes #447

blondejamtart opened this issue Jan 17, 2019 · 1 comment · Fixed by #452
Assignees
@blondejamtart
Labels
3 3 points

Comments

@blondejamtart
Copy link
Contributor

blondejamtart commented Jan 17, 2019 •
edited
Loading

MalcolmJS changes:

  • Parameter names should not be clickable
  • Plot is not updating on switching attribute
  • All methods should start with their parameters collapsed
  • tooltip and icon letter should distinguish Attributes/Methods/Parameters
  • There are missing dividing lines between Methods that have no parameters
  • clicking on the 'Configure - File Dir' parameter causes all Configure parameters to show as edited.
  • Discard parameter does not immediately update the 'edited' icon
  • Choosing the current design in the Design attribute should re-load saved design (i.e. discard changes)
  • A multi line label causes an indent of the value column
  • All checkboxes in the value column are too tall.

Require/are purely changes in pymalcolm:

  • Consider adding the ability to see PV name of an Attribute and copy it into the paste buffer
  • Change the name of parameter 'Completed Steps' in Pause Method to "Last Good Step"
  • Change the name of parameter 'Design' in Save Method to "Design Name"
@blondejamtart blondejamtart added ready in progress 2 2 points 3 3 points and removed ready 2 2 points labels Jan 17, 2019
@blondejamtart
Copy link
Contributor Author

Need to review styling for method dividers to check it is as desired

blondejamtart pushed a commit that referenced this issue Jan 17, 2019
Various minor tweaks and fixes (see #447)
a2776fb
@blondejamtart blondejamtart mentioned this issue Jan 30, 2019
Merged
@blondejamtart blondejamtart self-assigned this Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blondejamtart blondejamtart

Labels
3 3 points
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/plotter widget #448 DiamondLightSource/malcolmjs
1 participant
@blondejamtart