Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam centre lookup table should perform linear extrapolation #719

Open
rtuck99 opened this issue Dec 16, 2024 · 2 comments
Open

Beam centre lookup table should perform linear extrapolation #719

rtuck99 opened this issue Dec 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@rtuck99
Copy link
Contributor

rtuck99 commented Dec 16, 2024

The beam centre lookup table DetDistToBeamXYConverter.txt should perform linear extrapolation instead of reporting fixed values outside the lookup range.

See the following conversation at https://diamondlightsource.slack.com/archives/C048RD0KFFF/p1734351279634499

Steps To Reproduce

Steps to reproduce the behavior:

  1. Set the detector distance outside the LUT range
  2. The beam centre will be reported incorrectly in the nexus file and in ISPyB

Acceptance Criteria

  • Beam centre is extrapolated correctly
@rtuck99 rtuck99 added the bug Something isn't working label Dec 16, 2024
@rtuck99
Copy link
Contributor Author

rtuck99 commented Dec 16, 2024

We should take the opportunity to refactor the LUT logic slightly so that it can be placed in lookup_tables.py along with linear_interpolation_lut

@ndg63276
Copy link

Related to #522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants