Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent LPOP: Support for COUNT parameter #1057

Open
JyotinderSingh opened this issue Oct 10, 2024 · 8 comments
Open

Inconsistent LPOP: Support for COUNT parameter #1057

JyotinderSingh opened this issue Oct 10, 2024 · 8 comments

Comments

@JyotinderSingh
Copy link
Collaborator

Steps to reproduce

LPOP does not support the COUNT parameter.

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. addition of relevant test case to ensure we catch the regression

You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

@JyotinderSingh
Copy link
Collaborator Author

@Kripu77 should I assign this to you?

@Devashish08
Copy link

@JyotinderSingh can you assign this to me this will be my first issue so i can try to work on it

@Kripu77
Copy link
Contributor

Kripu77 commented Oct 10, 2024

Hi, @JyotinderSingh yes please assign this to me. Thank you

@JyotinderSingh
Copy link
Collaborator Author

@JyotinderSingh can you assign this to me this will be my first issue so i can try to work on it

Hi @Devashish08, since this issue was reported by @Kripu77 and they wanted to take it up, I've assigned it accordingly.
There are more open issues on the repo, please take a look!

@arpitbbhayani
Copy link
Contributor

Hello @Kripu77,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@Kripu77
Copy link
Contributor

Kripu77 commented Oct 24, 2024

Hello @Kripu77,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

Hi @arpitbbhayani

I have the updates ready, I just haven't got my time to work on the integration tests.

Please allow me some more time and I'll raise a PR.

Thanks

@apoorvyadav1111
Copy link
Contributor

Hi @Kripu77 , How are you? I am excited to hear about you progress on this issue.

@Kripu77
Copy link
Contributor

Kripu77 commented Dec 11, 2024

Hi @Kripu77 , How are you? I am excited to hear about you progress on this issue.

Hi @apoorvyadav1111 , please take a look at the PR. It includes support for COUNT parameter for both lpop & rpop commands.

#1365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants