Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate supported python versions #105

Closed
kevinkjt2000 opened this issue Jan 13, 2021 · 7 comments · Fixed by #107
Closed

Re-evaluate supported python versions #105

kevinkjt2000 opened this issue Jan 13, 2021 · 7 comments · Fixed by #107
Assignees
Labels

Comments

@kevinkjt2000
Copy link
Collaborator

One of the dependencies has dropped support for 3.5 (as mentioned in #104). Time to re-evaluate whether claiming support for python3.5 is worth it or not. May as well add 3.9 to the supported list too. If support is still necessary for 3.5, the dependency will have to be updated or replaced.

@Iapetus-11
Copy link
Contributor

The dependency that I was talking about would only be a dependency for an async way to check the status of a Bedrock Edition server, sorry if I caused any confusion.

@kevinkjt2000
Copy link
Collaborator Author

Still python 3.5 is already past EOL, so I plan to re-evaluate whether or not to support that going forward.

@Iapetus-11
Copy link
Contributor

Also in addition to being able to add async Bedrock Edition support more easily, since the query protocol uses UDP as well (iirc) we would benefit by being able to do that more easily as well.

@Iapetus-11
Copy link
Contributor

I contacted the developer of asyncio-dgram about if there was a specific reason for not supporting 3.5, and they went and added support for Python 3.5. Relevant issue: jsbronder/asyncio-dgram#6

@Egorrko
Copy link

Egorrko commented Jan 16, 2021

Btw dnspython v2.0 requires python => 3.6 and contains async query and resolver
https://dnspython.readthedocs.io/en/latest/async.html
https://pypi.org/project/dnspython/

@Iapetus-11
Copy link
Contributor

If it is decided to remove support for Python 3.5 I'd make a PR with async lookup functions that utilize the async resolver.

@kevinkjt2000
Copy link
Collaborator Author

3.5 is end of life already; long live python >= 3.6
I’ll raise a PR when I get a moment tomorrow to update Travis job and PyPi metadata. Feel free to ditch 3.5 during testing. Speaking of which, I should probably make a script that runs tests for each version in a local script/tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants