Fix: Make CSS Grid algorithm correctly apply max width/height and available space when it is the root node #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
force-pushed
the
fix/grid-respect-available-space
branch
3 times, most recently
from
2955c7c to
3c45374
Compare
nicoburns
force-pushed
the
fix/grid-respect-available-space
branch
from
3c45374 to
7e48f23
Compare
nicoburns
force-pushed
the
fix/grid-respect-available-space
branch
3 times, most recently
from
549b513 to
be7aeb1
Compare
nicoburns
changed the title
nicoburns
changed the title
nicoburns
changed the title
alice-i-cecile
approved these changes
Aug 14, 2023
… size is indefinite, and only do so for the final two track sizing steps.
nicoburns
force-pushed
the
fix/grid-respect-available-space
branch
from
be7aeb1 to
cb7596b
Compare
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
…ilable space when it is the root node (#491) * Add viewport control to gentest setup * Add tests for max-width and available space on a CSS Grid root node * Only treat definite available grid space as indefinite when container size is indefinite, and only do so for the final two track sizing steps.
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
…ilable space when it is the root node (#491) * Add viewport control to gentest setup * Add tests for max-width and available space on a CSS Grid root node * Only treat definite available grid space as indefinite when container size is indefinite, and only do so for the final two track sizing steps.
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
…ilable space when it is the root node (#491) * Add viewport control to gentest setup * Add tests for max-width and available space on a CSS Grid root node * Only treat definite available grid space as indefinite when container size is indefinite, and only do so for the final two track sizing steps.
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
…ilable space when it is the root node (#491) * Add viewport control to gentest setup * Add tests for max-width and available space on a CSS Grid root node * Only treat definite available grid space as indefinite when container size is indefinite, and only do so for the final two track sizing steps. (cherry picked from commit 9958624)
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
…ilable space when it is the root node (#491) * Add viewport control to gentest setup * Add tests for max-width and available space on a CSS Grid root node * Only treat definite available grid space as indefinite when container size is indefinite, and only do so for the final two track sizing steps. (cherry picked from commit 9958624)
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
…ilable space when it is the root node (#491) * Add viewport control to gentest setup * Add tests for max-width and available space on a CSS Grid root node * Only treat definite available grid space as indefinite when container size is indefinite, and only do so for the final two track sizing steps. (cherry picked from commit 9958624)
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
…ilable space when it is the root node (#491) * Add viewport control to gentest setup * Add tests for max-width and available space on a CSS Grid root node * Only treat definite available grid space as indefinite when container size is indefinite, and only do so for the final two track sizing steps. (cherry picked from commit 9958624)
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
…ilable space when it is the root node (#491) * Add viewport control to gentest setup * Add tests for max-width and available space on a CSS Grid root node * Only treat definite available grid space as indefinite when container size is indefinite, and only do so for the final two track sizing steps. (cherry picked from commit 9958624)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix bug that causes the CSS Grid algorithm to ignore:
when it is the root node.
Context
Feedback wanted
available_spaceparameter passed intocompute_layout) makes sense. In future, I'd like to extend this to allow testing multiple viewport sizes in a single test, and potentially to enable this by default across all tests.