🐛 Bug Report . level up before reaching xp limit

[DarkStar0534]

👟 Reproduction steps

I had 40/50xp i went on an adventure i got 5xp and i leveled up(to level 2) even the limit was 50xp not 45xp

👍 Expected behavior

level up tp level 2 after overgoing the xp limit

👎 Actual Behavior

levels up hefore reaching the level xp requirement

🎲 DRPG version

4.17.9

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

📝 Additional context

thank you for reading

[Willard21]

Pretty simple problem. We're adding xp, then checking new xp + gained xp for the next level. Just remove the + xpWin and it should be fixed.

[Sven65]

Not that big of an issue, player will still need to gather the required xp for the next level and I haven't seen it happen other than this report. Closing this issue.

[Willard21]

I sent a screenshot of the code that proves this happens 100% of the time... Why close a bug report when it's a bug and hasn't been fixed?

[Sven65]

Removing your code snippet does fix the issue, but breaks the XP progress bar in adventure embed 3.

See without;

and with

Considering that the logic is shared amongst the three display options, I don't see a straight-forward way of fixing the issue without specific logic for the xp progress bar.

[Sven65]

cc @Willard21, do you have any input on this?

[Willard21]

Which part did you remove? The userData.xp += xpWin or the + xpWin? The xp bar uses the current value of userData.xp so it should work fine with

userData.xp += xpWin
...
    levels: getLevelByXP(userData.xp)