[Bug]: Encryption key is required, but PCKBruteformer shows no encryption

[fatecyx]

Commit or version

a36d309

On which operating systems the error occurs

Windows

Issue description

When I attempt to "extract all," it prompts me for an encryption key. However, PCKBruteforcer indicates that the file is not encrypted. This discrepancy is confusing. I have attached the file for your reference.

https://drive.google.com/file/d/1VzilYM4a4LfHKDUNoUL63_-1CWDjToyE/view?usp=drive_link

Thank you for your assistance!

Steps to reproduce

N/A

[DmitriySalnikov]

When I attempt to "extract all," it prompts me for an encryption key.

For me, this happens at the end of the process, which means that only a few files are encrypted and were packed at the very end.
For some reason, I forgot during development of Bruteforcer that Godot has filters and not all files can really be encrypted in it 😅

And the funny thing is that the game developer most likely wanted to encrypt the entire game, but did it only for the icon :)

However, PCKBruteforcer indicates that the file is not encrypted.

This is expected, because I take into account all files when choosing the one suitable for brute force, and not just those that are encrypted.

GodotPCKExplorer/Bruteforcer/PCKBruteforcer/Bruteforcer.cs

Lines 173 to 174 in a36d309

	// First, find small files between 5KB and 1MB in size to have enough info for validation.
	var files = pck_reader.Files.Where((f) => f.Value.Size >= 1024 * 5 && f.Value.Size < 1024 * 1024).OrderBy((f) => f.Value.Size);

I will fix both Bruteforcer and most likely PCK Explorer, I will make it check immediately when extracting/opening for the presence of separate encrypted files.

---

I can't find the encryption key in this game. And in fact, even the game can't find it. Most likely, this is a mistake by the developers and they did not want to encrypt the game.