didScroll not triggering

[abel-n]

Version

3.5.5

Issue

I think didScroll doesn't trigger as it is supposed to according to docs. In addon/mixins/in-viewport.js:265 the triggering depends on viewportEntered option instead of viewportDidScroll.

    if (scrollDirection && directionChanged && get(this, 'viewportEntered')) {
      this.trigger('didScroll', scrollDirection);
      lastDirection[elementId] = scrollDirection;
    }

Although the docs mention didScroll will be turned off by default that is not the case yet.

Thank you for the great addon! 💪