Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting locationType and historySupportMiddleware still needed? #174

Closed
GCheung55 opened this issue Nov 30, 2018 · 1 comment · Fixed by #205
Closed

Setting locationType and historySupportMiddleware still needed? #174

GCheung55 opened this issue Nov 30, 2018 · 1 comment · Fixed by #205

Comments

@GCheung55
Copy link
Contributor

According to #54, it seems like step 3 in the docs, to update locationType and add historySupportMiddleware isn't needed. Is that correct?

If not, can we update the docs...?
@CvX CvX mentioned this issue Jul 23, 2019
Merged
@CvX
Copy link
Contributor

CvX commented Jul 23, 2019

The historySupportMiddleware option is still useful/required, but the locationType wasn't necessary for quite some time. I've opened #205 to update the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the locationType recommendation CvX/ember-router-scroll
2 participants
@GCheung55 @CvX