Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions and Webworker #37

Open
un0btanium opened this issue Apr 22, 2021 · 4 comments
Open

Transitions and Webworker #37

un0btanium opened this issue Apr 22, 2021 · 4 comments

Comments

@un0btanium
Copy link

Are smooth transitions possible with this? Or are these d3-graphviz v3 features?

Furthermore, I am receiving warnings in my react app and not quite sure what they mean or how to fix them. I assume this also causes a noticeable freeze in my application when a graph is being generated.

viz.js:60779 Invalid asm.js: Undefined global variable```
@magjac
Copy link

magjac commented Apr 22, 2021

Smooth transitions have been available in d3-graphviz since the first release.

I think you can safely ignore that error message. It comes from viz.js and I've never seen any problem because of them. Freezes will occur if you're not using the web worker version of d3-graphviz. I'm not sure which version graphviz-react uses.

@un0btanium
Copy link
Author

Hm, which one would be the web worker version of d3-graphviz. How would I find out?

@magjac
Copy link

magjac commented Apr 23, 2021

It's documented here, but I don't know how this is handled in graphviz-react. You have to look in the source code or wait for @DomParfitt to answer.

@DomParfitt
Copy link
Owner

To be honest I'm actually not sure about this myself. We don't set any extra script tags so my gut feeling is that it may not currently be working. I'll have a look and see how easy it would be to add this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants