Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle Menu Text: Not Japanese Order? #10

Open
marbuljon opened this issue Nov 1, 2023 · 1 comment
Open

Battle Menu Text: Not Japanese Order? #10

marbuljon opened this issue Nov 1, 2023 · 1 comment

Comments

@marbuljon
Copy link

marbuljon commented Nov 1, 2023

Could be incorrect here as I have not played your ROM yet, I was just looking at the code to get help for something and noticed the battle layout seemingly hadn't been changed to be like the Japanese, although you have changed many other things. The English battle text is:

BattleMenuText:
db "FIGHT PKMN"
next "ITEM RUN@"

The Japanese is:

BattleMenuText:
db "FIGHT BAG"
next "PKMN RUN@"

Additionally, at least in the screenshots on the homepage here, the Poke Ruble (₽) sign has not been changed to the Japanese 円 sign, nor has it been moved to after the numbers (50円 not ₽50).

I am not sure if you care about these differences, but based on the description of your hack, I assumed you might.

@Dracrius
Copy link
Owner

Dracrius commented May 10, 2024

Been off doing other things but decided to check in on this project. I wish github had done a better job letting me know people had posted issues apologies for the huge delay! I really appreciate these little details, main reason they are missing is just because I didn't know but it'll also take me a bit to figure out how to reorder the menu options but I'll likely give it a go.

For the currency marker though I had no idea I totally thought they made up the Poke Ruble for all I didn't know it had a different sign in the originals as I couldn't read enough to make it that far haha I'll get that fixed first with some other typo's if I can find them then I'll take a look into resorting the menu options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants