Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerbase.mk_copy extremely slow and memory hungry #294

Closed
2 tasks done
deichmab-draeger opened this issue Nov 30, 2023 · 0 comments · Fixed by #295
Closed
2 tasks done

Containerbase.mk_copy extremely slow and memory hungry #294

deichmab-draeger opened this issue Nov 30, 2023 · 0 comments · Fixed by #295
Labels
bug Something isn't working

Comments

@deichmab-draeger
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Copying 500 descriptors in a loop took 25 seconds and consumed 5 Gigabyte memory.
The reason for the memory consumption is that copying the node via xml_utils.copy_element seems to copy each time the whole tree below the node.
The slow speed is caused by

  • XPath expression is involved
  • a lot is copied
    • the computer starts swapping after a certain time.

The whole copy node thing is unusable for use inside sdc11073, esp. in transactions.

Expected Behavior

faster

Minimal Reproducible Example

No response

Solution proposal

change the default copy_node to False. This cures all problems inside sdc11073.

Python Version

all

Operating system

all

Sdc11073 Version

2.0.0a6

Link to sdc11073 Logs

No response

Further Information

No response

Participation

  • I am willing to submit a pull request to fix this bug.
@deichmab-draeger deichmab-draeger added the bug Something isn't working label Nov 30, 2023
@deichmab-draeger deichmab-draeger linked a pull request Nov 30, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant