-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images are washed out in double page mode #29
Comments
Can you share a sample of this? |
..I did? There are three labeled screenshots attached to the post. |
I mean the actual source not screenshots. |
Looks fine to me when using this page against itself for double page mode. Certainly nothing like your screenshot. |
Any chance I could get your mpv.conf? I played around with my settings a bit, only thing that seemed to change the rendering was the
|
This was with no relevant rendering settings. Just the defaults. This page has a pretty big resolution, so I suppose you're probably downscaling a lot more than me (my screen is 4k). |
You're right that part of the problem is downscaling. I was able to get much better rendering (close to and better than mcomix) for single pages with the settings below, but double page rendering is still very washed out. It can't just be scaling, I tried taking two pages and combining them into one image and that renders correctly, so I'd assume it has to be something going on with the lavfi filters but I don't know much (anything, really) about those so I couldn't guess as to what nor would I know where to start to try and troubleshoot it myself.
|
Can you try double page mode but without scaling the window? I'm not sure if your WM/DE will allow that, but I'd be curious if you notice any difference there in terms of visual output. |
adding |
It does look normal unscaled. So scaling is definitely still a factor. Something about how the lavfi filters and downscaler interact, I guess? 2024.06.24-19.06.01.mp4 |
I forgot how the scaling pipeline works with ffmpeg filters but evidently something weird must be happening here. Intuitively, I'm not sure why it would be causing a difference at all. In theory, all that the filter does is an hstack to put the images together (minus necessary scaling in certain cases because of mismatched image dimensions but this should not be relevant) and then mpv scales it later. Can't say I've noticed anything when upscaling (rarely I need to downscale), but maybe there's a similar problem. |
For what it's worth, I tried this out on my 1080p laptop and couldn't reproduce. Looks fine here. |
Images in double page mode are extremely washed out. Also true to a lesser extent in single page mode/without the plugin but that is unrelated to the script itself (if you have solutions for that though I'm all ears). Some image comparisons below. I've ensured that the brightness, contrast, etc are all default in both mpv and mcomix before taking these screenshots. I also checked on mpv master to make sure it wasn't related to #21 but it looks the same there too.
mcomix:
![mcomix](https://private-user-images.githubusercontent.com/32691832/342035022-5e40f288-7701-4c4f-bd85-41e68030fcf4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMzUxNzUsIm5iZiI6MTczOTAzNDg3NSwicGF0aCI6Ii8zMjY5MTgzMi8zNDIwMzUwMjItNWU0MGYyODgtNzcwMS00YzRmLWJkODUtNDFlNjgwMzBmY2Y0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDE3MTQzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQzOGUwMTRjMDgxOWZlYTBmNzIzOThhOWRkNjVkNmEzZGU1NDViNTE3MDEwYmJhMGM0ODEzZWZjZWNjZTk3YTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ypeTXlhSUDpyu0LnG8EY4FK3W4GPhWNdsVaXZM8w6Q4)
mpv without script/in single page mode:
![mpv-manga-single](https://private-user-images.githubusercontent.com/32691832/342035141-4d1ca098-e316-4bf7-91e7-ae9a946972ec.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMzUxNzUsIm5iZiI6MTczOTAzNDg3NSwicGF0aCI6Ii8zMjY5MTgzMi8zNDIwMzUxNDEtNGQxY2EwOTgtZTMxNi00YmY3LTkxZTctYWU5YTk0Njk3MmVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDE3MTQzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY0ZjNkZGVmOGExZWFlY2Q0YmE2ZGVkMjkwMTUxN2EzODliZDJhODQxMGYzZmRiZDI4OTI2YzA1NDg4NTEyMDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.duf55oMOqbC-f7b31oX3G74Ka7o694s4QutXKLblxFI)
mpv in double page mode (but cropped to a single page for easier comparison):
![mpv-manga-double](https://private-user-images.githubusercontent.com/32691832/342035204-eb33ba32-cce7-467e-8878-78d6014e488b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMzUxNzUsIm5iZiI6MTczOTAzNDg3NSwicGF0aCI6Ii8zMjY5MTgzMi8zNDIwMzUyMDQtZWIzM2JhMzItY2NlNy00NjdlLTg4NzgtNzhkNjAxNGU0ODhiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDE3MTQzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRhMjZkMDdkNWQyM2FjMDc2NWUxYWI5ZDBhYmQwMzM2ZWI0YjE4MDUzODA4ODA2MTcwOGQwYzM1YzRmMTRmOGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.BeG-HXY_KfAbnkNW6B7QTQnBTYhnOquVVvWGZSjOhC0)
The text was updated successfully, but these errors were encountered: