Skip to content
This repository was archived by the owner on Feb 23, 2025. It is now read-only.

ErrorDescription for LoginResult is null when response has description value #268

Closed
leonluc-dev opened this issue Dec 7, 2020 · 3 comments

Comments

@leonluc-dev
Copy link
Contributor

leonluc-dev commented Dec 7, 2020

OIDC compliant endpoints can return both an error (error type) and an error_description (error message) value in the result.
4.0.0-preview of OidcClient seemingly added the error_description property to the result classes as well.

For some reason however when using LoginAsync and the authorization process returns an error_description value the ErrorDescription property of LoginResult is still null.

This issue doesn't occur when refreshing tokens. The ErrorDescription property of RefreshTokenResult does fill properly when using RefreshTokenAsync and an error with an error_description value is present in the OIDC response.

@leonluc-dev
Copy link
Contributor Author

I've added propagation for the error_description value to the client and opened a pull request (#269)

@leastprivilege
Copy link
Contributor

thanks - merged!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants