Skip to content
This repository was archived by the owner on Feb 23, 2025. It is now read-only.

Please add IHttpClientFactory support #271

Closed
JohnGalt1717 opened this issue Dec 11, 2020 · 3 comments
Closed

Please add IHttpClientFactory support #271

JohnGalt1717 opened this issue Dec 11, 2020 · 3 comments

Comments

@JohnGalt1717
Copy link

JohnGalt1717 commented Dec 11, 2020

We're now using the excellent management practice of using HostBuilder for all of our clients (Xamarin/Uno). It would be really nice to be able to pass in HttpClient into the OdicClient. This would allow us to take advantage of IHttpClientFactory.

Edit: This also allows us to use Polly throughout the OidcClient pipeline without having to have OidcClient support polly directly.

@leastprivilege
Copy link
Contributor

Will look into it when I have time. Feel free to propose a PR.

@leastprivilege
Copy link
Contributor

I added a callback to integrate with arbitrary HTTP client creation strategies - would that help?

#327

I am closing this issue - feel free to comment on the PR.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants