Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

Expose Authentication time in token response #363

Closed
vbjay opened this issue Dec 19, 2020 · 9 comments
Closed

Expose Authentication time in token response #363

vbjay opened this issue Dec 19, 2020 · 9 comments
Labels

Comments

@vbjay
Copy link

vbjay commented Dec 19, 2020

See DuendeArchive/IdentityModel.OidcClient#277.

The TokenResponse should expose the auth_time value.

@leastprivilege
Copy link
Contributor

I disagree. auth_time is a claim. TokenResponse models an OAuth token response. This is a protocol libary.

@vbjay
Copy link
Author

vbjay commented Dec 19, 2020

Ok. Makes sense. So instead just fix the expires in type and update the oidc client to get the claim?

@vbjay
Copy link
Author

vbjay commented Dec 19, 2020

I just think if you allow for expires_in, that auth_time should be included also.

@vbjay
Copy link
Author

vbjay commented Dec 19, 2020

I just added a fixup commit that makes it nullable. d411689

@leastprivilege
Copy link
Contributor

I just think if you allow for expires_in, that auth_time should be included also.

a) expires_in is about the access token (OAuth), auth_time is the time of the user authentication (OIDC)
b) expires_in is a official specified response parameter in OAuth, auth_time is a claim in the ID token (this library would first need to validate the token before it can use values from it).

https://tools.ietf.org/html/rfc6749#section-4.1.4

@vbjay
Copy link
Author

vbjay commented Dec 19, 2020

I see. I'll move it to oidcclient. Thanks.

@vbjay vbjay closed this as completed Dec 19, 2020
@vbjay vbjay reopened this Dec 19, 2020
@vbjay
Copy link
Author

vbjay commented Dec 19, 2020

I'll adjust the pull request to just do the epires_in fix.

@vbjay
Copy link
Author

vbjay commented Dec 19, 2020

Ok. Expires_in isn't the same as the identity token's expires_in. I'll rework in oidc client.

@vbjay vbjay closed this as completed Dec 19, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants