Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro conflicts when using multiple motion systems #965

Closed
dc42 opened this issue Mar 6, 2024 · 3 comments
Closed

Macro conflicts when using multiple motion systems #965

dc42 opened this issue Mar 6, 2024 · 3 comments
Assignees
Labels
bug Bug that has been reproduced Done - Needs Testing
Milestone

Comments

@dc42
Copy link
Collaborator

dc42 commented Mar 6, 2024

When the firmware supports multiple motion systems, macros invoked by a job file are executed by both motion systems. This often causes macros to fail if they haven't been designed with this in mind. For example, the conditions within if, elif and while commands may rely on global variables that haven't been created yet. See https://forum.duet3d.com/topic/35023/mutiple-motion-systems-macro-conflicts-in-3-5.

@dc42 dc42 added this to the 3.5.0 milestone Mar 6, 2024
@dc42 dc42 self-assigned this Mar 6, 2024
@dc42
Copy link
Collaborator Author

dc42 commented Mar 6, 2024

Fixes proposed:

  1. Change behaviour so that the 'abort' command is only executed by the input stream that executes commands for the active motion system (as is already the case for global, set global and echo commands).
  2. Add a new M606 command to request execution of multiple motion systems by separate file readers explicitly. Until this command is seen, use the File stream to execute all commands.

@dc42
Copy link
Collaborator Author

dc42 commented Mar 6, 2024

Implemented fix 1 above in 3.5-dev branch. Created new branch 3.5-mms-changes and implemented fix 2 in it. Binaries at https://www.dropbox.com/scl/fo/3y4agkmfzfmqcifuecqo3/h?rlkey=j0kibs1tubm5dfj7o2vz1vbzj&dl=0 have been made available to users for testing.

@dc42 dc42 added bug Bug that has been reproduced Done - Needs Testing labels Mar 6, 2024
@dc42
Copy link
Collaborator Author

dc42 commented Mar 15, 2024

3.5-mms-changes now merged into 3.5-dev.

@dc42 dc42 closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that has been reproduced Done - Needs Testing
Projects
None yet
Development

No branches or pull requests

1 participant