Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature units for Celsius #20

Open
mdeceglie opened this issue Jul 11, 2020 · 6 comments
Open

Temperature units for Celsius #20

mdeceglie opened this issue Jul 11, 2020 · 6 comments

Comments

@mdeceglie
Copy link
Contributor

The temperature units are currently expressed as C, which is technically the SI symbol for coulomb. For parameters like temperature_cell Celsius is natural, so I suggest using °C. For units where temperature appears in the denominator, kelvin may be more appropriate. For example, in Table 4 on this NIST site derived units use kelvin.

@cwhanse
Copy link
Collaborator

cwhanse commented Jul 13, 2020

Are you suggesting that the documentation text include the degree symbol, or that the unit be changed to K? I'm not in favor of the K option.

The degree symbol is awkward to type (ALT+0176 on a Windows keyboard) but could be added to the documentation file.

@mdeceglie
Copy link
Contributor Author

Yes, for temperatures such as temperature_cell I am suggesting that the documentation text and definitions.csv include the degree symbol. The units as they are now, without it, specify coulombs.

For units where the temperature appears in the denominator such as gamma_pmp I suggest changing to K, but could go either way on this point as long as the degree symbol is included along with C.

@toddkarin
Copy link
Contributor

Sounds good to me. For gamma_pmp, do we want W/°C or W/K? I'd vote for W/°C for the engineering crowd.

@cwhanse
Copy link
Collaborator

cwhanse commented Jul 13, 2020

We can try adding the degree symbol to a line in definitions.csv and see how it renders. @mdeceglie @toddkarin care to make a PR?

@mdeceglie
Copy link
Contributor Author

I'll give it a shot and open a PR. Thanks!

@steve-ransome
Copy link

If "°" <alt + 0176> causes problems I've seen degC used before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants