-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temperature units for Celsius #20
Comments
Are you suggesting that the documentation text include the degree symbol, or that the unit be changed to K? I'm not in favor of the K option. The degree symbol is awkward to type (ALT+0176 on a Windows keyboard) but could be added to the documentation file. |
Yes, for temperatures such as For units where the temperature appears in the denominator such as |
Sounds good to me. For gamma_pmp, do we want W/°C or W/K? I'd vote for W/°C for the engineering crowd. |
We can try adding the degree symbol to a line in definitions.csv and see how it renders. @mdeceglie @toddkarin care to make a PR? |
I'll give it a shot and open a PR. Thanks! |
If "°" <alt + 0176> causes problems I've seen degC used before. |
The temperature units are currently expressed as
C
, which is technically the SI symbol for coulomb. For parameters liketemperature_cell
Celsius is natural, so I suggest using °C. For units where temperature appears in the denominator, kelvin may be more appropriate. For example, in Table 4 on this NIST site derived units use kelvin.The text was updated successfully, but these errors were encountered: