Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set of labels for different technologies #26

Open
toddkarin opened this issue Jul 27, 2020 · 7 comments
Open

Set of labels for different technologies #26

toddkarin opened this issue Jul 27, 2020 · 7 comments

Comments

@toddkarin
Copy link
Contributor

We should also standardize the labeling for different technologies, for example, pvlib.ivtools.fit_sdm_cec_sam uses the list:

  • 'monoSi', 'multiSi', 'polySi', 'cis', 'cigs', 'cdte', 'amorphous'

while the cec database pvlib.pvsystem.retrieve_sam uses:

  • 'Thin Film', 'Multi-c-Si', 'CIGS', 'Mono-c-Si', 'CdTe'

PVsyst on the other hand uses:

  • Si-poly, Si-mono, and others.

Without giving this too much thought, I would probably pick the first option and add this to pvterms. @cwhanse what do you think?

@steve-ransome
Copy link

Should HIT be added, and either micromorph or else say how many junctions with the amorphous? For clarity how are multi and poly distinguished as the terms have sometimes been used interchangeably.

@toddkarin
Copy link
Contributor Author

The current purpose of these labels is mostly to choose band gaps and material properties for describing the cells, but in the future other applications could be expected. I would say that we want to limit the technology description to descriptions typically available on a datasheet. HIT could be added perhaps as a second level descriptor. Here's an idea:

Technology level 1

  • mono-Si
  • multi-Si
  • amorphous-Si
  • thin-film
  • cigs
  • cdte
  • other

Technology level 2 (flexible labels?)

  • HIT
  • 3 junction
  • GaAs

@cwhanse
Copy link
Collaborator

cwhanse commented Jul 28, 2020

I'm in favor of agreeing on some string values for cell types.

FYI, in the first two cases @toddkarin lists, pvlib is accommodating terms used by SAM. For fit_sdm_cec_sam there's no choice but to use the SAM cell type label, it's passed as a value through the SAM API. For retrieve_sam, pvlib is returning the string value that appears in the CEC module database distributed with SAM.

@toddkarin
Copy link
Contributor Author

Yes, I understand. Of course, we can rename cell technology in pvlib when importing from the other libraries. @cwhanse do you have an opinion on the selection and formatting? I think the CEC database naming is a little clunky and would prefer something like what I suggested above.

@cwhanse
Copy link
Collaborator

cwhanse commented Jul 28, 2020

I'd suggest avoiding special characters (e.g., no spaces or hyphens), and not starting a value with a numeral if practical. As far as 'monoSi' vs. 'Si-mono', mild preference for the first, but I can see the benefit of the PVsyst style if one is scanning a list of values.

@toddkarin
Copy link
Contributor Author

I would advocate for the hyphen, it makes things a little easier to parse and adds readability: Simono, thinfilm are not that great.

What about capitalization? It's not consistent to have monoSi and cdte.

@shirubana
Copy link

(Random comment --- I seem to remember HIT is specifically for Panasonic trademarked, otherwise they have to be called HJT? )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants