-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set of labels for different technologies #26
Comments
Should HIT be added, and either micromorph or else say how many junctions with the amorphous? For clarity how are multi and poly distinguished as the terms have sometimes been used interchangeably. |
The current purpose of these labels is mostly to choose band gaps and material properties for describing the cells, but in the future other applications could be expected. I would say that we want to limit the technology description to descriptions typically available on a datasheet. HIT could be added perhaps as a second level descriptor. Here's an idea: Technology level 1
Technology level 2 (flexible labels?)
|
I'm in favor of agreeing on some string values for cell types. FYI, in the first two cases @toddkarin lists, pvlib is accommodating terms used by SAM. For |
Yes, I understand. Of course, we can rename cell technology in pvlib when importing from the other libraries. @cwhanse do you have an opinion on the selection and formatting? I think the CEC database naming is a little clunky and would prefer something like what I suggested above. |
I'd suggest avoiding special characters (e.g., no spaces or hyphens), and not starting a value with a numeral if practical. As far as 'monoSi' vs. 'Si-mono', mild preference for the first, but I can see the benefit of the PVsyst style if one is scanning a list of values. |
I would advocate for the hyphen, it makes things a little easier to parse and adds readability: Simono, thinfilm are not that great. What about capitalization? It's not consistent to have monoSi and cdte. |
(Random comment --- I seem to remember HIT is specifically for Panasonic trademarked, otherwise they have to be called HJT? ) |
We should also standardize the labeling for different technologies, for example, pvlib.ivtools.fit_sdm_cec_sam uses the list:
while the cec database pvlib.pvsystem.retrieve_sam uses:
PVsyst on the other hand uses:
Without giving this too much thought, I would probably pick the first option and add this to pvterms. @cwhanse what do you think?
The text was updated successfully, but these errors were encountered: