Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and publish #8

Open
Dzarda7 opened this issue Feb 22, 2023 · 9 comments
Open

Update and publish #8

Dzarda7 opened this issue Feb 22, 2023 · 9 comments

Comments

@Dzarda7
Copy link

Dzarda7 commented Feb 22, 2023

Hello, first of all, thank you for this library. I forked it and found that it is also compatible with FT5436, so I just added chip IDs and made it compatible with both. I also added rotation functionality. It would be awesome if it will be in arduino library manager and PlatformIO libraries. If I open pull request, will you do it please? Else I can do it with my fork.

Thank you so much.

@DustinWatts
Copy link
Owner

Hi @Dzarda7 Sure.. I will look at any pull request. And if there are no issues I will merge!

Thanks for your work on this!

@Dzarda7
Copy link
Author

Dzarda7 commented Feb 23, 2023

And will you publish it into library manager of arduino and PlatformIO? Thanks.

@marcelstoer
Copy link

And will you publish it into library manager of Arduino and PlatformIO?

Just checked out this project and asked myself the same question 😄 Glad I don't need to create an issue (and PR as you already raised #9).

@DustinWatts
Copy link
Owner

DustinWatts commented Mar 2, 2023

@marcelstoer Lol... it always helps checking other issues 😉

@Dzarda7 I don't know if I can push it in to the PlatformIO and Arduino manager, because there are already a a few and I used soms Adafruit code. I did credit them in the library but I don't know how this works publishing. I will figure this out.

Furthermore, I am really busy atm, so things might move slowly, but that is a time-management thingy on my edit 😄

@Dzarda7
Copy link
Author

Dzarda7 commented Mar 2, 2023

Thank you Dustin. It should be ok to publish it in my opinion, because all of it is under MIT licence. I can definitely understand that time management problem 😃. Please do that when you find some time and let me know I would really appreciate it.

@marcelstoer
Copy link

there are already a a few

That's right, but...

  • LovyanGFX is a bit of a monster to use IMO
  • htcw_ft6336 and FocalTech_Library were created around the same time as your project and I assume you must have had a good reason not to use either of them

@DustinWatts
Copy link
Owner

@marcelstoer Yes. The reason is that this library is part of a much bigger project FreeTouchDeck and this way I could fix and have control over most libraries used in that project.

@marcelstoer
Copy link

marcelstoer commented Apr 2, 2023

@DustinWatts #9 adds library.json required for the PlatformIO registry.

How to publish the library:

Once #9 is merged the project is pretty much ready for submission. It won't take long.

@benlye
Copy link

benlye commented Jul 27, 2023

Just adding to what's said above - thanks for the library, and it would be amazing if it were published to the PlatformIO registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants