Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small corrections in ormqr! error messages #37

Closed
andreasvarga opened this issue Nov 29, 2023 · 2 comments
Closed

Small corrections in ormqr! error messages #37

andreasvarga opened this issue Nov 29, 2023 · 2 comments

Comments

@andreasvarga
Copy link

I think the following lines in ormqr!

            if side == 'L' && m != mA
                throw(DimensionMismatch("for a left-sided multiplication, the first dimension of C, $m, must equal the second dimension of A, $mA"))
            end
            if side == 'R' && n != mA
                throw(DimensionMismatch("for a right-sided multiplication, the second dimension of C, $m, must equal the second dimension of A, $mA"))
            end

should be

            if side == 'L' && m != mA
                throw(DimensionMismatch("for a left-sided multiplication, the first dimension of C, $m, must equal the first dimension of A, $mA"))
            end
            if side == 'R' && n != mA
                throw(DimensionMismatch("for a right-sided multiplication, the second dimension of C, $m, must equal the first dimension of A, $mA"))
            end

Similar modifications are necessary also in the function
Base.resize!(ormws::QROrmWs, side::AbstractChar, trans::AbstractChar, ...

and also in the original LAPACK wrapper for ormqr!.

@MichelJuillard
Copy link
Member

I think that you are right. Thanks

@MichelJuillard
Copy link
Member

Fixed in commit 37c14d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants