Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace _FillValue with NC_FillValue #613

Open
jayeshkrishna opened this issue Oct 17, 2024 · 1 comment
Open

Replace _FillValue with NC_FillValue #613

jayeshkrishna opened this issue Oct 17, 2024 · 1 comment
Assignees

Comments

@jayeshkrishna
Copy link
Contributor

Newer versions of the NetCDF library only supports NC_FillValue instead of _FillValue to avoid conflicts with the C++ library headers. We also need to move (with appropriate config checks) to using NC_FillValue.

Also see Unidata/netcdf-c#2858 , https://github.com/Unidata/netcdf-c/blob/main/RELEASE_NOTES.md

@jayeshkrishna jayeshkrishna self-assigned this Oct 17, 2024
@wkliao
Copy link
Member

wkliao commented Oct 17, 2024

I think the safest way for users of NetCDF4 is to use string "_FillValue" directly.
That way Scorpio can be built with any NetCDF4 versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants