You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #281, I tried removing a trailing comma and the validator passed, even though it has historically failed in such cases -- see #290. I tried setting active = 4, which I would have expected to fail since active expects a bool value; however validation passed and a ValueError: Invalid value 4 for 'active' appeared during runtime.
It appears that something has changed in the validation process.
The text was updated successfully, but these errors were encountered:
$ git checkout -b test-validation 00828089733cc3ad9351e4a98902bd20fce5c163
$ emacs tests/integration/test_complete_run.cfg
# Set `active = 4`, remove a trailing comma for `years`
$ pip install .
$ zppy -c tests/integration/test_complete_run.cfg
# Behavior is the same as above.
This occurs regardless of using a conda environment from July 2022 or from building a conda environment based on the setup of the code in Feb. 2022.
It looks like the configuration file validation (https://github.com/E3SM-Project/zppy/blob/main/zppy/__main__.py#L169) isn't working anymore.
While working on #281, I tried removing a trailing comma and the validator passed, even though it has historically failed in such cases -- see #290. I tried setting
active = 4
, which I would have expected to fail sinceactive
expects abool
value; however validation passed and aValueError: Invalid value 4 for 'active'
appeared during runtime.It appears that something has changed in the validation process.
The text was updated successfully, but these errors were encountered: