Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test update commands #540

Closed
3 tasks done
forsyth2 opened this issue Jan 10, 2024 · 2 comments · Fixed by #554
Closed
3 tasks done

Fix test update commands #540

forsyth2 opened this issue Jan 10, 2024 · 2 comments · Fixed by #554
Labels
Testing Files in `tests` modified

Comments

@forsyth2
Copy link
Collaborator

Request criteria

  • I searched the zppy GitHub Discussions to find a similar question and didn't find it.
  • I searched the zppy documentation.
  • This issue does not match the other templates (i.e., it is not a bug report, documentation request, feature request, or a question.)

Issue description

In https://github.com/E3SM-Project/zppy/blob/main/tests/integration/template_directions.md, the line rm -rf #expand user_www#forsyth/zppy_test_bundles_www/<UNIQUE ID>/v2.LR.historical_0201/image_check_failures erroneously includes "forsyth". That should be removed.

@forsyth2 forsyth2 added the Testing Files in `tests` modified label Jan 10, 2024
@forsyth2
Copy link
Collaborator Author

The same error appears for the complete-run test line.

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Jan 12, 2024

Actually the change should be:

# Remove the image check failures, so they don't end up in the expected files.
rm -rf /lcrc/group/e3sm/public_html/diagnostic_output/ac.forsyth2/forsyth/zppy_test_complete_run_www/<UNIQUE ID>/v2.LR.historical_0201/image_check_failures

=>

# Remove the image check failures, so they don't end up in the expected files.
rm -rf image_check_failures_complete_run

This change also needs to be done for bundles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Files in `tests` modified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant