Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update process to run/maintain the curation_queue_with_ancestry.py script #174

Open
twhetzel opened this issue Aug 17, 2020 · 2 comments
Open
Labels

Comments

@twhetzel
Copy link
Collaborator

The script "curation_queue_with_ancestry.py" in the "gwas-curation-utils" repo, which is used to create one of the curation metrics, is set-up with the older style of managing local and remote versions of the script to prevent sensitive information being exposed in GitHub. This should be updated so all of the sensitive information can be provided through a wrapper shell script so that the Python code can be properly maintained in GitHub. This process of using a wrapper script is used by more recent Python scripts in this project, e.g. "reported-traits" and can follow that pattern.

The "curation_queue_with_ancestry.py" script is run by the Bamboo build plan "GWAS Curation Queue Metrics" and should be checked for any updates needed based on updates for running the script.

@twhetzel twhetzel added the Utils label Aug 17, 2020
@twhetzel twhetzel self-assigned this Aug 17, 2020
@twhetzel
Copy link
Collaborator Author

Note: this script also needs to be updated: study-sample-review/check_studydesign_sampleinfo.py

@ljwh2
Copy link
Contributor

ljwh2 commented Feb 3, 2021

@sprintell does this need doing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants