From 0d3090a316940253a968ea36943d61e151cff917 Mon Sep 17 00:00:00 2001 From: lucafedeli88 Date: Mon, 4 Mar 2024 17:09:49 +0100 Subject: [PATCH 1/4] split clang-tidy checks to improve performances --- .../{clang_tidy.yml => clang_tidy_1D.yml} | 2 +- .github/workflows/clang_tidy_2D.yml | 73 +++++++++++++++++++ .github/workflows/clang_tidy_3D.yml | 73 +++++++++++++++++++ .github/workflows/clang_tidy_RZ.yml | 73 +++++++++++++++++++ 4 files changed, 220 insertions(+), 1 deletion(-) rename .github/workflows/{clang_tidy.yml => clang_tidy_1D.yml} (98%) create mode 100644 .github/workflows/clang_tidy_2D.yml create mode 100644 .github/workflows/clang_tidy_3D.yml create mode 100644 .github/workflows/clang_tidy_RZ.yml diff --git a/.github/workflows/clang_tidy.yml b/.github/workflows/clang_tidy_1D.yml similarity index 98% rename from .github/workflows/clang_tidy.yml rename to .github/workflows/clang_tidy_1D.yml index c166941f6e2..50f63260275 100644 --- a/.github/workflows/clang_tidy.yml +++ b/.github/workflows/clang_tidy_1D.yml @@ -37,7 +37,7 @@ jobs: cmake -S . -B build_clang_tidy \ -DCMAKE_VERBOSE_MAKEFILE=ON \ - -DWarpX_DIMS="1;2;RZ;3" \ + -DWarpX_DIMS="1" \ -DWarpX_MPI=ON \ -DWarpX_COMPUTE=OMP \ -DWarpX_PSATD=ON \ diff --git a/.github/workflows/clang_tidy_2D.yml b/.github/workflows/clang_tidy_2D.yml new file mode 100644 index 00000000000..459092e2e75 --- /dev/null +++ b/.github/workflows/clang_tidy_2D.yml @@ -0,0 +1,73 @@ +name: 🧹 clang-tidy + +on: [push, pull_request] + +concurrency: + group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy + cancel-in-progress: true + +jobs: + run_clang_tidy: + name: clang-tidy + runs-on: ubuntu-22.04 + if: github.event.pull_request.draft == false + steps: + - uses: actions/checkout@v4 + - name: install dependencies + run: | + .github/workflows/dependencies/clang15.sh + - name: set up cache + uses: actions/cache@v4 + with: + path: ~/.cache/ccache + key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} + restore-keys: | + ccache-${{ github.workflow }}-${{ github.job }}-git- + - name: build WarpX & run clang-tidy + run: | + export CCACHE_COMPRESS=1 + export CCACHE_COMPRESSLEVEL=10 + export CCACHE_MAXSIZE=300M + export CCACHE_EXTRAFILES=${{ github.workspace }}/.clang-tidy + export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt + ccache -z + + export CXX=$(which clang++-15) + export CC=$(which clang-15) + + cmake -S . -B build_clang_tidy \ + -DCMAKE_VERBOSE_MAKEFILE=ON \ + -DWarpX_DIMS="2" \ + -DWarpX_MPI=ON \ + -DWarpX_COMPUTE=OMP \ + -DWarpX_PSATD=ON \ + -DWarpX_QED=ON \ + -DWarpX_QED_TABLE_GEN=ON \ + -DWarpX_OPENPMD=ON \ + -DWarpX_PRECISION=SINGLE \ + -DCMAKE_CXX_COMPILER_LAUNCHER=ccache + + cmake --build build_clang_tidy -j 4 + + ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt + make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ + CLANG_TIDY=clang-tidy-15 \ + CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*" + + ccache -s + du -hs ~/.cache/ccache + + save_pr_number: + if: github.event_name == 'pull_request' + runs-on: ubuntu-latest + steps: + - name: Save PR number + env: + PR_NUMBER: ${{ github.event.number }} + run: | + echo $PR_NUMBER > pr_number.txt + - uses: actions/upload-artifact@v4 + with: + name: pr_number + path: pr_number.txt + retention-days: 1 diff --git a/.github/workflows/clang_tidy_3D.yml b/.github/workflows/clang_tidy_3D.yml new file mode 100644 index 00000000000..d0fb9ab62dd --- /dev/null +++ b/.github/workflows/clang_tidy_3D.yml @@ -0,0 +1,73 @@ +name: 🧹 clang-tidy + +on: [push, pull_request] + +concurrency: + group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy + cancel-in-progress: true + +jobs: + run_clang_tidy: + name: clang-tidy + runs-on: ubuntu-22.04 + if: github.event.pull_request.draft == false + steps: + - uses: actions/checkout@v4 + - name: install dependencies + run: | + .github/workflows/dependencies/clang15.sh + - name: set up cache + uses: actions/cache@v4 + with: + path: ~/.cache/ccache + key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} + restore-keys: | + ccache-${{ github.workflow }}-${{ github.job }}-git- + - name: build WarpX & run clang-tidy + run: | + export CCACHE_COMPRESS=1 + export CCACHE_COMPRESSLEVEL=10 + export CCACHE_MAXSIZE=300M + export CCACHE_EXTRAFILES=${{ github.workspace }}/.clang-tidy + export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt + ccache -z + + export CXX=$(which clang++-15) + export CC=$(which clang-15) + + cmake -S . -B build_clang_tidy \ + -DCMAKE_VERBOSE_MAKEFILE=ON \ + -DWarpX_DIMS="3" \ + -DWarpX_MPI=ON \ + -DWarpX_COMPUTE=OMP \ + -DWarpX_PSATD=ON \ + -DWarpX_QED=ON \ + -DWarpX_QED_TABLE_GEN=ON \ + -DWarpX_OPENPMD=ON \ + -DWarpX_PRECISION=SINGLE \ + -DCMAKE_CXX_COMPILER_LAUNCHER=ccache + + cmake --build build_clang_tidy -j 4 + + ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt + make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ + CLANG_TIDY=clang-tidy-15 \ + CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*" + + ccache -s + du -hs ~/.cache/ccache + + save_pr_number: + if: github.event_name == 'pull_request' + runs-on: ubuntu-latest + steps: + - name: Save PR number + env: + PR_NUMBER: ${{ github.event.number }} + run: | + echo $PR_NUMBER > pr_number.txt + - uses: actions/upload-artifact@v4 + with: + name: pr_number + path: pr_number.txt + retention-days: 1 diff --git a/.github/workflows/clang_tidy_RZ.yml b/.github/workflows/clang_tidy_RZ.yml new file mode 100644 index 00000000000..e97c6a15ca4 --- /dev/null +++ b/.github/workflows/clang_tidy_RZ.yml @@ -0,0 +1,73 @@ +name: 🧹 clang-tidy + +on: [push, pull_request] + +concurrency: + group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy + cancel-in-progress: true + +jobs: + run_clang_tidy: + name: clang-tidy + runs-on: ubuntu-22.04 + if: github.event.pull_request.draft == false + steps: + - uses: actions/checkout@v4 + - name: install dependencies + run: | + .github/workflows/dependencies/clang15.sh + - name: set up cache + uses: actions/cache@v4 + with: + path: ~/.cache/ccache + key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} + restore-keys: | + ccache-${{ github.workflow }}-${{ github.job }}-git- + - name: build WarpX & run clang-tidy + run: | + export CCACHE_COMPRESS=1 + export CCACHE_COMPRESSLEVEL=10 + export CCACHE_MAXSIZE=300M + export CCACHE_EXTRAFILES=${{ github.workspace }}/.clang-tidy + export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt + ccache -z + + export CXX=$(which clang++-15) + export CC=$(which clang-15) + + cmake -S . -B build_clang_tidy \ + -DCMAKE_VERBOSE_MAKEFILE=ON \ + -DWarpX_DIMS="RZ" \ + -DWarpX_MPI=ON \ + -DWarpX_COMPUTE=OMP \ + -DWarpX_PSATD=ON \ + -DWarpX_QED=ON \ + -DWarpX_QED_TABLE_GEN=ON \ + -DWarpX_OPENPMD=ON \ + -DWarpX_PRECISION=SINGLE \ + -DCMAKE_CXX_COMPILER_LAUNCHER=ccache + + cmake --build build_clang_tidy -j 4 + + ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt + make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ + CLANG_TIDY=clang-tidy-15 \ + CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*" + + ccache -s + du -hs ~/.cache/ccache + + save_pr_number: + if: github.event_name == 'pull_request' + runs-on: ubuntu-latest + steps: + - name: Save PR number + env: + PR_NUMBER: ${{ github.event.number }} + run: | + echo $PR_NUMBER > pr_number.txt + - uses: actions/upload-artifact@v4 + with: + name: pr_number + path: pr_number.txt + retention-days: 1 From c2083ac8a98dc6455750fc293daf24dcf8dadcb8 Mon Sep 17 00:00:00 2001 From: lucafedeli88 Date: Mon, 4 Mar 2024 17:18:08 +0100 Subject: [PATCH 2/4] rename folders and tests --- .github/workflows/clang_tidy_1D.yml | 26 +++++++++++++------------- .github/workflows/clang_tidy_2D.yml | 26 +++++++++++++------------- .github/workflows/clang_tidy_3D.yml | 26 +++++++++++++------------- .github/workflows/clang_tidy_RZ.yml | 26 +++++++++++++------------- 4 files changed, 52 insertions(+), 52 deletions(-) diff --git a/.github/workflows/clang_tidy_1D.yml b/.github/workflows/clang_tidy_1D.yml index 50f63260275..7164f1a8b2f 100644 --- a/.github/workflows/clang_tidy_1D.yml +++ b/.github/workflows/clang_tidy_1D.yml @@ -1,4 +1,4 @@ -name: 🧹 clang-tidy +name: 🧹 clang-tidy-1D on: [push, pull_request] @@ -8,7 +8,7 @@ concurrency: jobs: run_clang_tidy: - name: clang-tidy + name: clang-tidy-1D runs-on: ubuntu-22.04 if: github.event.pull_request.draft == false steps: @@ -35,19 +35,19 @@ jobs: export CXX=$(which clang++-15) export CC=$(which clang-15) - cmake -S . -B build_clang_tidy \ - -DCMAKE_VERBOSE_MAKEFILE=ON \ - -DWarpX_DIMS="1" \ - -DWarpX_MPI=ON \ - -DWarpX_COMPUTE=OMP \ - -DWarpX_PSATD=ON \ - -DWarpX_QED=ON \ - -DWarpX_QED_TABLE_GEN=ON \ - -DWarpX_OPENPMD=ON \ - -DWarpX_PRECISION=SINGLE \ + cmake -S . -B build_clang_tidy_1D \ + -DCMAKE_VERBOSE_MAKEFILE=ON \ + -DWarpX_DIMS="1" \ + -DWarpX_MPI=ON \ + -DWarpX_COMPUTE=OMP \ + -DWarpX_PSATD=ON \ + -DWarpX_QED=ON \ + -DWarpX_QED_TABLE_GEN=ON \ + -DWarpX_OPENPMD=ON \ + -DWarpX_PRECISION=SINGLE \ -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - cmake --build build_clang_tidy -j 4 + cmake --build build_clang_tidy_1D -j 4 ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ diff --git a/.github/workflows/clang_tidy_2D.yml b/.github/workflows/clang_tidy_2D.yml index 459092e2e75..d3dfe85f728 100644 --- a/.github/workflows/clang_tidy_2D.yml +++ b/.github/workflows/clang_tidy_2D.yml @@ -1,4 +1,4 @@ -name: 🧹 clang-tidy +name: 🧹 clang-tidy-2D on: [push, pull_request] @@ -8,7 +8,7 @@ concurrency: jobs: run_clang_tidy: - name: clang-tidy + name: clang-tidy-2D runs-on: ubuntu-22.04 if: github.event.pull_request.draft == false steps: @@ -35,19 +35,19 @@ jobs: export CXX=$(which clang++-15) export CC=$(which clang-15) - cmake -S . -B build_clang_tidy \ - -DCMAKE_VERBOSE_MAKEFILE=ON \ - -DWarpX_DIMS="2" \ - -DWarpX_MPI=ON \ - -DWarpX_COMPUTE=OMP \ - -DWarpX_PSATD=ON \ - -DWarpX_QED=ON \ - -DWarpX_QED_TABLE_GEN=ON \ - -DWarpX_OPENPMD=ON \ - -DWarpX_PRECISION=SINGLE \ + cmake -S . -B build_clang_tidy_2D \ + -DCMAKE_VERBOSE_MAKEFILE=ON \ + -DWarpX_DIMS="2" \ + -DWarpX_MPI=ON \ + -DWarpX_COMPUTE=OMP \ + -DWarpX_PSATD=ON \ + -DWarpX_QED=ON \ + -DWarpX_QED_TABLE_GEN=ON \ + -DWarpX_OPENPMD=ON \ + -DWarpX_PRECISION=SINGLE \ -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - cmake --build build_clang_tidy -j 4 + cmake --build build_clang_tidy_2D -j 4 ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ diff --git a/.github/workflows/clang_tidy_3D.yml b/.github/workflows/clang_tidy_3D.yml index d0fb9ab62dd..b994b62431f 100644 --- a/.github/workflows/clang_tidy_3D.yml +++ b/.github/workflows/clang_tidy_3D.yml @@ -1,4 +1,4 @@ -name: 🧹 clang-tidy +name: 🧹 clang-tidy-3D on: [push, pull_request] @@ -8,7 +8,7 @@ concurrency: jobs: run_clang_tidy: - name: clang-tidy + name: clang-tidy-3D runs-on: ubuntu-22.04 if: github.event.pull_request.draft == false steps: @@ -35,19 +35,19 @@ jobs: export CXX=$(which clang++-15) export CC=$(which clang-15) - cmake -S . -B build_clang_tidy \ - -DCMAKE_VERBOSE_MAKEFILE=ON \ - -DWarpX_DIMS="3" \ - -DWarpX_MPI=ON \ - -DWarpX_COMPUTE=OMP \ - -DWarpX_PSATD=ON \ - -DWarpX_QED=ON \ - -DWarpX_QED_TABLE_GEN=ON \ - -DWarpX_OPENPMD=ON \ - -DWarpX_PRECISION=SINGLE \ + cmake -S . -B build_clang_tidy_3D \ + -DCMAKE_VERBOSE_MAKEFILE=ON \ + -DWarpX_DIMS="3" \ + -DWarpX_MPI=ON \ + -DWarpX_COMPUTE=OMP \ + -DWarpX_PSATD=ON \ + -DWarpX_QED=ON \ + -DWarpX_QED_TABLE_GEN=ON \ + -DWarpX_OPENPMD=ON \ + -DWarpX_PRECISION=SINGLE \ -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - cmake --build build_clang_tidy -j 4 + cmake --build build_clang_tidy_3D -j 4 ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ diff --git a/.github/workflows/clang_tidy_RZ.yml b/.github/workflows/clang_tidy_RZ.yml index e97c6a15ca4..b2a57460532 100644 --- a/.github/workflows/clang_tidy_RZ.yml +++ b/.github/workflows/clang_tidy_RZ.yml @@ -1,4 +1,4 @@ -name: 🧹 clang-tidy +name: 🧹 clang-tidy-RZ on: [push, pull_request] @@ -8,7 +8,7 @@ concurrency: jobs: run_clang_tidy: - name: clang-tidy + name: clang-tidy-RZ runs-on: ubuntu-22.04 if: github.event.pull_request.draft == false steps: @@ -35,19 +35,19 @@ jobs: export CXX=$(which clang++-15) export CC=$(which clang-15) - cmake -S . -B build_clang_tidy \ - -DCMAKE_VERBOSE_MAKEFILE=ON \ - -DWarpX_DIMS="RZ" \ - -DWarpX_MPI=ON \ - -DWarpX_COMPUTE=OMP \ - -DWarpX_PSATD=ON \ - -DWarpX_QED=ON \ - -DWarpX_QED_TABLE_GEN=ON \ - -DWarpX_OPENPMD=ON \ - -DWarpX_PRECISION=SINGLE \ + cmake -S . -B build_clang_tidy_RZ \ + -DCMAKE_VERBOSE_MAKEFILE=ON \ + -DWarpX_DIMS="RZ" \ + -DWarpX_MPI=ON \ + -DWarpX_COMPUTE=OMP \ + -DWarpX_PSATD=ON \ + -DWarpX_QED=ON \ + -DWarpX_QED_TABLE_GEN=ON \ + -DWarpX_OPENPMD=ON \ + -DWarpX_PRECISION=SINGLE \ -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - cmake --build build_clang_tidy -j 4 + cmake --build build_clang_tidy_RZ -j 4 ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ From dd6250e7ce6209b8c38542b05c4d0403bc7f23b9 Mon Sep 17 00:00:00 2001 From: lucafedeli88 Date: Mon, 4 Mar 2024 17:26:00 +0100 Subject: [PATCH 3/4] fix concurrency --- .github/workflows/clang_tidy_1D.yml | 2 +- .github/workflows/clang_tidy_2D.yml | 2 +- .github/workflows/clang_tidy_3D.yml | 2 +- .github/workflows/clang_tidy_RZ.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/clang_tidy_1D.yml b/.github/workflows/clang_tidy_1D.yml index 7164f1a8b2f..ea43b8a581d 100644 --- a/.github/workflows/clang_tidy_1D.yml +++ b/.github/workflows/clang_tidy_1D.yml @@ -3,7 +3,7 @@ name: 🧹 clang-tidy-1D on: [push, pull_request] concurrency: - group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy + group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy-1D cancel-in-progress: true jobs: diff --git a/.github/workflows/clang_tidy_2D.yml b/.github/workflows/clang_tidy_2D.yml index d3dfe85f728..37b4e5aa51a 100644 --- a/.github/workflows/clang_tidy_2D.yml +++ b/.github/workflows/clang_tidy_2D.yml @@ -3,7 +3,7 @@ name: 🧹 clang-tidy-2D on: [push, pull_request] concurrency: - group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy + group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy-2D cancel-in-progress: true jobs: diff --git a/.github/workflows/clang_tidy_3D.yml b/.github/workflows/clang_tidy_3D.yml index b994b62431f..65665d8c06d 100644 --- a/.github/workflows/clang_tidy_3D.yml +++ b/.github/workflows/clang_tidy_3D.yml @@ -3,7 +3,7 @@ name: 🧹 clang-tidy-3D on: [push, pull_request] concurrency: - group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy + group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy-3D cancel-in-progress: true jobs: diff --git a/.github/workflows/clang_tidy_RZ.yml b/.github/workflows/clang_tidy_RZ.yml index b2a57460532..55634d90407 100644 --- a/.github/workflows/clang_tidy_RZ.yml +++ b/.github/workflows/clang_tidy_RZ.yml @@ -3,7 +3,7 @@ name: 🧹 clang-tidy-RZ on: [push, pull_request] concurrency: - group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy + group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy-RZ cancel-in-progress: true jobs: From 36a9917116c54bf20d5b420f1b41e2ad5b5cf9b5 Mon Sep 17 00:00:00 2001 From: Axel Huebl Date: Thu, 7 Mar 2024 10:16:32 +0900 Subject: [PATCH 4/4] Simplify --- .../{clang_tidy_1D.yml => clang_tidy.yml} | 31 ++++---- .github/workflows/clang_tidy_2D.yml | 73 ------------------- .github/workflows/clang_tidy_3D.yml | 73 ------------------- .github/workflows/clang_tidy_RZ.yml | 73 ------------------- 4 files changed, 17 insertions(+), 233 deletions(-) rename .github/workflows/{clang_tidy_1D.yml => clang_tidy.yml} (72%) delete mode 100644 .github/workflows/clang_tidy_2D.yml delete mode 100644 .github/workflows/clang_tidy_3D.yml delete mode 100644 .github/workflows/clang_tidy_RZ.yml diff --git a/.github/workflows/clang_tidy_1D.yml b/.github/workflows/clang_tidy.yml similarity index 72% rename from .github/workflows/clang_tidy_1D.yml rename to .github/workflows/clang_tidy.yml index ea43b8a581d..5abb42352f4 100644 --- a/.github/workflows/clang_tidy_1D.yml +++ b/.github/workflows/clang_tidy.yml @@ -1,14 +1,17 @@ -name: 🧹 clang-tidy-1D +name: 🧹 clang-tidy on: [push, pull_request] concurrency: - group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy-1D + group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy cancel-in-progress: true jobs: run_clang_tidy: - name: clang-tidy-1D + strategy: + matrix: + dim: [1, 2, RZ, 3] + name: clang-tidy-${{ matrix.dim }}D runs-on: ubuntu-22.04 if: github.event.pull_request.draft == false steps: @@ -35,19 +38,19 @@ jobs: export CXX=$(which clang++-15) export CC=$(which clang-15) - cmake -S . -B build_clang_tidy_1D \ - -DCMAKE_VERBOSE_MAKEFILE=ON \ - -DWarpX_DIMS="1" \ - -DWarpX_MPI=ON \ - -DWarpX_COMPUTE=OMP \ - -DWarpX_PSATD=ON \ - -DWarpX_QED=ON \ - -DWarpX_QED_TABLE_GEN=ON \ - -DWarpX_OPENPMD=ON \ - -DWarpX_PRECISION=SINGLE \ + cmake -S . -B build_clang_tidy \ + -DCMAKE_VERBOSE_MAKEFILE=ON \ + -DWarpX_DIMS="${{ matrix.dim }}" \ + -DWarpX_MPI=ON \ + -DWarpX_COMPUTE=OMP \ + -DWarpX_PSATD=ON \ + -DWarpX_QED=ON \ + -DWarpX_QED_TABLE_GEN=ON \ + -DWarpX_OPENPMD=ON \ + -DWarpX_PRECISION=SINGLE \ -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - cmake --build build_clang_tidy_1D -j 4 + cmake --build build_clang_tidy -j 4 ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ diff --git a/.github/workflows/clang_tidy_2D.yml b/.github/workflows/clang_tidy_2D.yml deleted file mode 100644 index 37b4e5aa51a..00000000000 --- a/.github/workflows/clang_tidy_2D.yml +++ /dev/null @@ -1,73 +0,0 @@ -name: 🧹 clang-tidy-2D - -on: [push, pull_request] - -concurrency: - group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy-2D - cancel-in-progress: true - -jobs: - run_clang_tidy: - name: clang-tidy-2D - runs-on: ubuntu-22.04 - if: github.event.pull_request.draft == false - steps: - - uses: actions/checkout@v4 - - name: install dependencies - run: | - .github/workflows/dependencies/clang15.sh - - name: set up cache - uses: actions/cache@v4 - with: - path: ~/.cache/ccache - key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} - restore-keys: | - ccache-${{ github.workflow }}-${{ github.job }}-git- - - name: build WarpX & run clang-tidy - run: | - export CCACHE_COMPRESS=1 - export CCACHE_COMPRESSLEVEL=10 - export CCACHE_MAXSIZE=300M - export CCACHE_EXTRAFILES=${{ github.workspace }}/.clang-tidy - export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt - ccache -z - - export CXX=$(which clang++-15) - export CC=$(which clang-15) - - cmake -S . -B build_clang_tidy_2D \ - -DCMAKE_VERBOSE_MAKEFILE=ON \ - -DWarpX_DIMS="2" \ - -DWarpX_MPI=ON \ - -DWarpX_COMPUTE=OMP \ - -DWarpX_PSATD=ON \ - -DWarpX_QED=ON \ - -DWarpX_QED_TABLE_GEN=ON \ - -DWarpX_OPENPMD=ON \ - -DWarpX_PRECISION=SINGLE \ - -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - - cmake --build build_clang_tidy_2D -j 4 - - ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt - make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ - CLANG_TIDY=clang-tidy-15 \ - CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*" - - ccache -s - du -hs ~/.cache/ccache - - save_pr_number: - if: github.event_name == 'pull_request' - runs-on: ubuntu-latest - steps: - - name: Save PR number - env: - PR_NUMBER: ${{ github.event.number }} - run: | - echo $PR_NUMBER > pr_number.txt - - uses: actions/upload-artifact@v4 - with: - name: pr_number - path: pr_number.txt - retention-days: 1 diff --git a/.github/workflows/clang_tidy_3D.yml b/.github/workflows/clang_tidy_3D.yml deleted file mode 100644 index 65665d8c06d..00000000000 --- a/.github/workflows/clang_tidy_3D.yml +++ /dev/null @@ -1,73 +0,0 @@ -name: 🧹 clang-tidy-3D - -on: [push, pull_request] - -concurrency: - group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy-3D - cancel-in-progress: true - -jobs: - run_clang_tidy: - name: clang-tidy-3D - runs-on: ubuntu-22.04 - if: github.event.pull_request.draft == false - steps: - - uses: actions/checkout@v4 - - name: install dependencies - run: | - .github/workflows/dependencies/clang15.sh - - name: set up cache - uses: actions/cache@v4 - with: - path: ~/.cache/ccache - key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} - restore-keys: | - ccache-${{ github.workflow }}-${{ github.job }}-git- - - name: build WarpX & run clang-tidy - run: | - export CCACHE_COMPRESS=1 - export CCACHE_COMPRESSLEVEL=10 - export CCACHE_MAXSIZE=300M - export CCACHE_EXTRAFILES=${{ github.workspace }}/.clang-tidy - export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt - ccache -z - - export CXX=$(which clang++-15) - export CC=$(which clang-15) - - cmake -S . -B build_clang_tidy_3D \ - -DCMAKE_VERBOSE_MAKEFILE=ON \ - -DWarpX_DIMS="3" \ - -DWarpX_MPI=ON \ - -DWarpX_COMPUTE=OMP \ - -DWarpX_PSATD=ON \ - -DWarpX_QED=ON \ - -DWarpX_QED_TABLE_GEN=ON \ - -DWarpX_OPENPMD=ON \ - -DWarpX_PRECISION=SINGLE \ - -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - - cmake --build build_clang_tidy_3D -j 4 - - ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt - make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ - CLANG_TIDY=clang-tidy-15 \ - CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*" - - ccache -s - du -hs ~/.cache/ccache - - save_pr_number: - if: github.event_name == 'pull_request' - runs-on: ubuntu-latest - steps: - - name: Save PR number - env: - PR_NUMBER: ${{ github.event.number }} - run: | - echo $PR_NUMBER > pr_number.txt - - uses: actions/upload-artifact@v4 - with: - name: pr_number - path: pr_number.txt - retention-days: 1 diff --git a/.github/workflows/clang_tidy_RZ.yml b/.github/workflows/clang_tidy_RZ.yml deleted file mode 100644 index 55634d90407..00000000000 --- a/.github/workflows/clang_tidy_RZ.yml +++ /dev/null @@ -1,73 +0,0 @@ -name: 🧹 clang-tidy-RZ - -on: [push, pull_request] - -concurrency: - group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy-RZ - cancel-in-progress: true - -jobs: - run_clang_tidy: - name: clang-tidy-RZ - runs-on: ubuntu-22.04 - if: github.event.pull_request.draft == false - steps: - - uses: actions/checkout@v4 - - name: install dependencies - run: | - .github/workflows/dependencies/clang15.sh - - name: set up cache - uses: actions/cache@v4 - with: - path: ~/.cache/ccache - key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} - restore-keys: | - ccache-${{ github.workflow }}-${{ github.job }}-git- - - name: build WarpX & run clang-tidy - run: | - export CCACHE_COMPRESS=1 - export CCACHE_COMPRESSLEVEL=10 - export CCACHE_MAXSIZE=300M - export CCACHE_EXTRAFILES=${{ github.workspace }}/.clang-tidy - export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt - ccache -z - - export CXX=$(which clang++-15) - export CC=$(which clang-15) - - cmake -S . -B build_clang_tidy_RZ \ - -DCMAKE_VERBOSE_MAKEFILE=ON \ - -DWarpX_DIMS="RZ" \ - -DWarpX_MPI=ON \ - -DWarpX_COMPUTE=OMP \ - -DWarpX_PSATD=ON \ - -DWarpX_QED=ON \ - -DWarpX_QED_TABLE_GEN=ON \ - -DWarpX_OPENPMD=ON \ - -DWarpX_PRECISION=SINGLE \ - -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - - cmake --build build_clang_tidy_RZ -j 4 - - ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt - make -j4 --keep-going -f clang-tidy-ccache-misses.mak \ - CLANG_TIDY=clang-tidy-15 \ - CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*" - - ccache -s - du -hs ~/.cache/ccache - - save_pr_number: - if: github.event_name == 'pull_request' - runs-on: ubuntu-latest - steps: - - name: Save PR number - env: - PR_NUMBER: ${{ github.event.number }} - run: | - echo $PR_NUMBER > pr_number.txt - - uses: actions/upload-artifact@v4 - with: - name: pr_number - path: pr_number.txt - retention-days: 1