Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_taxa_map(): More flexible arg specifications #32

Open
ctc3d opened this issue Dec 7, 2019 · 1 comment
Open

create_taxa_map(): More flexible arg specifications #32

ctc3d opened this issue Dec 7, 2019 · 1 comment

Comments

@ctc3d
Copy link

ctc3d commented Dec 7, 2019

It could be nice to be able to specify the output filename so successive taxa_map.csv's won't overwrite each other.

Possibly unreasonable but:
My input files come in all kinds of formats; sometimes genus and species are in separate columns. Any way to specify something like col=c('Gen', 'Spec')?

Docs quibble:
The reference page for create_taxa_map() says "Value: A .csv file named (taxa_map.csv) written to path containing the fields:..." But that's a side-effect, right? And the value is the df returned?

@clnsmth
Copy link
Contributor

clnsmth commented Dec 21, 2019

Thanks for these suggestions @ctc3d.

Explicitly defining inputs and outputs would definitely be an enhancement. We'll do this.

Accommodating genus and species inputs from separate columns could be supported, but would complicate updating the source data with revise_taxa(). This could probably be supported.

Since taxa_map.csv is an output from the function it has been included within the roxygen @return tag. However, I've updated the documentation (in the development branch) to list "data frame" as an output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants