-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host injections, lmod hooks and moving gpu-related host-injection instructions #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stallation chapter
…s the variant symlink is specific to the EESSI repositories
xinan1911
reviewed
Jun 18, 2024
xinan1911
reviewed
Jun 18, 2024
xinan1911
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Merged and closed. |
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
host_injections
directory was introduced as part of theAdvanced Usage => Accelerator support => GPUs
. I think we better introduce the concept ofhost_injections
being a location that can be used for site-specific EESSI configuration first. Since this is about configuration, it makes sense to me to do this as part of theInstallation
instructions. I also imagine that theInstallation
chapter would be the only chapter that sysadmins read, so in my opinion it should contain everything needed to install and configure EESSI to it's full functionality (including GPU support, MPI tuning, etc).I've also added new documentation on how to write
Lmod
hooks inhost_injections
. This basically provides the documentation for the functionality added in this PR.