remove references to 'pilot', switch to software.eessi.io #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trz42
commented
Nov 23, 2023
tasks/build.py
Outdated
| if repo_id != "EESSI-pilot" and repo_id not in repocfg: | ||
| # ensure repocfg contains information about the repository repo_id if repo_id != EESSI | ||
| # Note, EESSI is a bad/misleading name, it should be more like AS_IN_CONTAINER | ||
| if repo_id != "EESSI" and repo_id not in repocfg: |
There was a problem hiding this comment.
use startswith to ensure that EESSI-pilot still works
OR
use explicit or
boegel
requested changes
Nov 23, 2023
Co-authored-by: Kenneth Hoste <[email protected]>
boegel
requested changes
Nov 26, 2023
Co-authored-by: Kenneth Hoste <[email protected]>
boegel
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly changes in examples, README.md and tests. Only a single code file (
tasks/build.py) had to be changed.Implementation (use with bot instances) should be coordinated with software-layer PR EESSI/software-layer#383