Fix non-bot jobs leaking into known_jobs + make sure that job manager logs to correct file
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While non-bot jobs are not processed in process_new_job they could still leak into the list of known jobs via ```python known_jobs = current_jobs at the end of the main loop in the job manager. To fix this we collect a list of non-bot jobs and remove them from the dictionary current_jobs just before that is assigned to known_jobs. The function process_new_job was slightly modified to return False if it processes a non-bot job and True otherwise.
Also using f-strings when using '{var}'.
… fix-non-bot-job-leaking Pull in recentlt merged PRs.
|
Verified on another cluster that this works. So, PR is ready to be reviewed. |
boegel
requested changes
Nov 21, 2022
boegel
changed the title
known_jobsknown_jobs + make sure that job manager logs to correct file
boegel
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on AWS cluster (see trz42/software-layer#46 (comment)). Will run a final test using this PR as it includes recently merged PRs (no conflicts) and minor tweaks to the logging from the job manager.
Follow-up to #63
Closes #33