-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hooks should be defined in SitePackage.lua, not in lmodrc.lua #491
Comments
The positive thing is we should still be able to do that in a way that allows sites to customise the hooks. We can point to our |
In fact, it's mostly a renaming exercise: our
we're done (I think). We do need to probably make sure that |
Defining hooks in
lmodrc.lua
works if thelmodrc.lua
files are read early enough in the process of amodule load
. However, #490 (comment) shows that this is only the case under certain circumstances, and by no way a guarantee. We should probably move registration of the hooks toSitePackage.lua
, as this is the officially document location for hooks https://lmod.readthedocs.io/en/latest/170_hooks.html?highlight=hook#hook-functionsThe text was updated successfully, but these errors were encountered: