Fix permission denied when echoing to /dev/stdout
#415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instance
|
trz42
changed the title
echoing to /dev/stdout
ocaisa
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Seems to work fine:
ocaisa@LAPTOP-O6HF2IKC:~$ cat bash.func
function show_msg {
# only echo msg if EESSI_SILENT is unset
msg=$1
if [[ ! -v EESSI_SILENT ]]; then
echo "$msg"
fi
}
ocaisa@LAPTOP-O6HF2IKC:~$ source bash.func
ocaisa@LAPTOP-O6HF2IKC:~$ show_msg test
test
ocaisa@LAPTOP-O6HF2IKC:~$ EESSI_SILENT=1 show_msg test
ocaisa@LAPTOP-O6HF2IKC:~$
|
@boegel I'm not sure how this would actually get deployed so I'm reluctant to hit merge |
We basically need to redo the procedure for ingesting the init scripts: that means merging this PR, creating a new tarball using https://github.com/EESSI/software-layer/blob/2023.06-software.eessi.io/create_directory_tarballs.sh, and uploading the tarball to the S3 bucket using https://github.com/EESSI/eessi-bot-software-layer/blob/develop/scripts/eessi-upload-to-staging. |
|
tarball |
TopRichard
added a commit
to TopRichard/software-layer
that referenced
this pull request
Jul 2, 2024
….18-GCC/12.3.0
{2023.06}[GCC/12.3.0] BCFtools V1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases,
echoing to/dev/stdouttriggers a permission denied. Particularly, this happens when sourcing the init script (init/bash) or the script to set key EESSI environment variables (init/eessi_environment_variables). See #413This PR works around the issue by implementing a fix suggested in https://unix.stackexchange.com/a/38580
fixes #413