Prefer archdetect in our scripts, also make EESSI compatible with archspec 0.2.3+
#485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instance
|
|
This is still missing the most important part, the update to https://github.com/EESSI/software-layer/blob/2023.06-software.eessi.io/init/eessi_software_subdir_for_host.py |
ocaisa
commented
Feb 29, 2024
…o fix_archspec_usage_for_0.2.3
…o fix_archspec_usage_for_0.2.3
ocaisa
commented
Jul 30, 2024
EESSI-install-software.sh
Outdated
Comment on lines
145
to
153
| possible_subdir_paths=$(bash $TOPDIR/init/eessi_archdetect.sh -a cpupath) | ||
|
|
||
| if [[ "$GENERIC" -eq 1 ]]; then | ||
| # Last path is the generic case | ||
| override_subdir="${possible_subdir_paths##*:}" | ||
| else | ||
| # First path is the best option (according to archspec) | ||
| override_subdir="${possible_subdir_paths%%:*}" | ||
| fi |
There was a problem hiding this comment.
Just to note, this works as expected
~$ /cvmfs/software.eessi.io/versions/2023.06/init/eessi_archdetect.sh -a cpupath
x86_64/intel/skylake_avx512:x86_64/intel/haswell:x86_64/generic
~$ possible_subdir_paths=$(/cvmfs/software.eessi.io/versions/2023.06/init/eessi_archdetect.sh -a cpupath)
~$ echo ${possible_subdir_paths##*:}
x86_64/generic
~$ echo ${possible_subdir_paths%%:*}
x86_64/intel/skylake_avx512
~$ possible_subdir_paths="x86_64/generic"
~$ echo ${possible_subdir_paths%%:*}
x86_64/generic
~$ echo ${possible_subdir_paths##*:}
x86_64/generic
ocaisa
commented
Jul 30, 2024
…ware-layer into fix_archspec_usage_for_0.2.3
ocaisa
changed the title
archdetect in our scripts
ocaisa
changed the title
archdetect in our scriptsarchdetect in our scripts, also make EESSI compatible with archspec 0.2.3+
ocaisa
commented
Aug 9, 2024
ocaisa
commented
Aug 9, 2024
ocaisa
commented
Aug 9, 2024
|
Groan, this is very out-of-sync now, I might just split it into two new PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.