Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Commit

Permalink
Remove unused variables and fix syntax manually
Browse files Browse the repository at this point in the history
  • Loading branch information
Chan Chak Shing committed Aug 9, 2018
1 parent db2b8b6 commit e8f27ee
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions utils/trivialize-rules/trivialize-rules.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@ files.fork().zipAll([ sources.fork(), rules ]).map(([name, source, ruleset]) =>
let securecookies = ruleset.securecookie ? ruleset.securecookie.map(sc => sc.$) : new Array();
let rules = ruleset.rule.map(rule => rule.$);

let shouldRemoveSecurecookies = false;

if (rules.length === 1 && isTrivial(rules[0])) {
return;
}
Expand Down Expand Up @@ -227,7 +225,7 @@ files.fork().zipAll([ sources.fork(), rules ]).map(([name, source, ruleset]) =>
warn`Unsupported regexp part ${e.message} while traversing securecookie : ${JSON.stringify(securecookie)}`;
return [false, false];
}

for (const domain of localDomains) {
if (domains.indexOf(domain) === -1) {
warn`Ruleset does not cover target ${domain} for securecookie : ${JSON.stringify(securecookie)}`;
Expand Down Expand Up @@ -271,17 +269,16 @@ files.fork().zipAll([ sources.fork(), rules ]).map(([name, source, ruleset]) =>
if (shouldRemove) {
let scReSrc = `\n([\t ]*)<securecookie\\s*host=\\s*"${escapeStringRegexp(securecookie.host)}"(\\s*)name=\\s*"${escapeStringRegexp(securecookie.name)}"\\s*?/>[\t ]*\n`;
let scRe = new RegExp(scReSrc);

if (scRe && scRe.test(source)) {
source = source.replace(scRe, '');
} else {
fail`Failed to construct regexp which matches securecookie: ${JSON.stringify(securecookie)}`;
return ;
return;
}
}
} else {
// Skip this ruleset as it contain non-static securecookies
return ;
return;
}
}

Expand All @@ -293,7 +290,6 @@ files.fork().zipAll([ sources.fork(), rules ]).map(([name, source, ruleset]) =>
info`trivialized`;

return writeFile(`${rulesDir}/${name}`, source);

})
.filter(Boolean)
.parallel(10)
Expand Down

0 comments on commit e8f27ee

Please sign in to comment.