"Reset to Defaults" option does not work on Firefox

[cschanaj]

Type: code issue

Platform     Debian 9
Browser      Firefox 60.0.2 (64-bit)
Extension    HTTPS Everywhere 2018.6.13

and I am getting the same error on Tor Browser with updated HTTPSE. Apparently, this does not affect the chromium browser and Firefox on Windows platform... not sure why this is happening though...

Output of the extension console

"TypeError: can't access dead object"

[cschanaj]

@Hainish Apparently, the confirmation dialog is the culprit.

Firefox/Linux will close the popup when users make their choices while this does not happen on Firefox/Windows or Chromium/Any, so I am guessing this is a bug on Firefox's side...

https://bugzilla.mozilla.org/show_bug.cgi?id=1292701

Remove the if statement resolve this issue immediately (this will get ride of the confirmation dialog), but I'm not sure if this will have any negative effect on the UX design. Another option is to use a third party library like bootstrap to create a model for confirmation. What's your opinion?

https-everywhere/chromium/pages/popup/ux.js

Line 167 in 737363d

if (confirm(chrome.i18n.getMessage("prefs_reset_defaults_message"))) {

A person posted a workaround on Stack overflow, but I'm afraid it is too complicated for such a simple feature we have.

https://stackoverflow.com/questions/48666167/firefox-webextension-confirm-function-causes-extension-popup-to-close-immediat

cc @Bisaloo @J0WI @jeremyn

[Hainish]

Let's revisit this once we implement the suggestions in #16669 (this will hopefully be very soon).

In the meantime I'm fine with removing the confirmation dialogue altogether.