This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Update Ghostery related rulesets #10849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also #10843. |
ghost
mentioned this pull request
69 tasks
|
@cschanaj Thanks! |
J0WI
reviewed
Jul 21, 2017
| - help.ghosteryenterprise.com | ||
| - my-cdn.ghosteryenterprise.com | ||
| - site-cdn1.ghosteryenterprise.com | ||
| - site-cdn2.ghosteryenterprise.com |
There was a problem hiding this comment.
What about 3, 4, 5, 6, 7, 8, 9, 10 and without any number?
There was a problem hiding this comment.
Thanks!
You can also user RegEx for such comments btw.
There was a problem hiding this comment.
I don't prefer regex because I am used to extract the commented domain in the following way. Thanks anyway!!
grep ' - ' Ruleset.xml | sed 's/\s*- \(.*\).*/\1/g'
J0WI
reviewed
Jul 21, 2017
| <!-- Direct rewrites: | ||
| --> | ||
| <ruleset name="Evidon Inc (partial)"> | ||
| <!-- *betrad.com --> |
There was a problem hiding this comment.
Please add at least ^and www (same for evidon)
ghost
mentioned this pull request
41 tasks
luciancor
pushed a commit
to luciancor/https-everywhere
that referenced
this pull request
Aug 24, 2017
* Update Ghostery related rulesets * Update Evidon.xml and Ghostery_Enterprise.com.xml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9906