Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Trivialize snapping redirects (^C, experimental) #11024

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Trivialize snapping redirects (^C, experimental) #11024

merged 1 commit into from
Jul 11, 2017

Conversation

cschanaj
Copy link
Collaborator

@cschanaj cschanaj commented Jul 11, 2017

No ruleset needed to be excluded.

@@ -5,6 +5,5 @@
<securecookie host="www\.cuidadodesalud\.gov"
name=".+" />

<rule from="^(?:http://(?:www\.)?|https://)cuidadodesalud\.gov/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's weird. There are around 18 rules like this.

@J0WI
Copy link
Contributor

J0WI commented Jul 11, 2017

For some reason there are Disabled by https-everywhere-checker because: comments in some rulesets, but this is unrelated to your change. Maybe another cleanup task.

@J0WI J0WI merged commit a7d4969 into EFForg:master Jul 11, 2017
@J0WI
Copy link
Contributor

J0WI commented Jul 11, 2017

Sorry, I just discovered that there are some outdated comments in the ruleset, like Cert only matches www or mismatch on ^. I'm not sure if we can change them by script.

@cschanaj cschanaj deleted the cschanaj-trr-004 branch July 12, 2017 03:54
@cschanaj
Copy link
Collaborator Author

@J0WI I don't think removing the outdated comment can be done trivially by script. Unlike rewriting direct rewrite as in #10872, removing snapping rewrite actually introduce new rules to the code base . In some rare case (I don't have an example), it can be problematic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants