Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Do not process URLs that use file or ftp scheme #11231

Closed
wants to merge 6 commits into from
Closed

Do not process URLs that use file or ftp scheme #11231

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 18, 2017

@J0WI
Copy link
Contributor

J0WI commented Jul 19, 2017

*://*/* does still match ftp://foo/bar. Maybe http is enough? (see #10843)
cc @Hainish

@ghost
Copy link
Author

ghost commented Jul 19, 2017

@J0WI No: https://developer.chrome.com/extensions/match_patterns.

@ghost
Copy link
Author

ghost commented Jul 19, 2017 •
edited by ghost
Loading

@J0WI http isn't currently enough.

@J0WI J0WI removed the conflict label Jul 19, 2017
@Hainish
Copy link
Member

Hainish commented Jul 19, 2017

Merged in 8e302ec

@Hainish Hainish closed this Jul 19, 2017
Hainish pushed a commit that referenced this pull request Jul 19, 2017
@Hainish
Do not process URLs that use file or ftp scheme (#11231)
8e302ec
@ghost ghost deleted the patch-107 branch July 21, 2017 08:36
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
@luciancor
Do not process URLs that use file or ftp scheme (EFForg#11231)
b22a67c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J0WI @Hainish