This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add a script to trivialize a special form of securecookies #16540
Merged
Hainish
merged 13 commits into
EFForg:master
from
cschanaj:trivialize-special-form-securecookies-1
Sep 29, 2018
Merged
Add a script to trivialize a special form of securecookies #16540
Hainish
merged 13 commits into
EFForg:master
from
cschanaj:trivialize-special-form-securecookies-1
Sep 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes LGTM. |
J0WI
approved these changes
Sep 17, 2018
I have found another pattern which can be trivialized in a similar way, namely
affecting 450+ rulesets. So it will be great if the script got reviewed before I proceed with further trivialization (in another PR). P.S. for a list of affected rulesets |
@J0WI @Hainish Sorry that I have to push e55f367 to resolve the merge conflicts. P.S. It might worth merging this asap to avoid possible merge conflicts. For #16540 (comment), if needed, I can submit another PR to change the script and let @Hainish to review it. |
24 tasks
@Hainish would you be interested in looking at the script in this PR as well? |
Looking good - thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #16539 close #16536 close #16537 close #16538 related #16029