Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Add a script to trivialize a special form of securecookies #16540

Merged
merged 13 commits into from
Sep 29, 2018
Merged

Add a script to trivialize a special form of securecookies #16540

merged 13 commits into from
Sep 29, 2018

Conversation

cschanaj
Copy link
Collaborator

@cschanaj cschanaj commented Sep 16, 2018

supersedes #16539 close #16536 close #16537 close #16538 related #16029

@Hainish Hainish added the top-1k label Sep 16, 2018
@cschanaj cschanaj closed this Sep 16, 2018
@cschanaj cschanaj reopened this Sep 16, 2018
@cschanaj cschanaj changed the title Add script to trivialize a special forms of securecookies Add script to trivialize a special form of securecookies Sep 16, 2018
@cschanaj cschanaj changed the title Add script to trivialize a special form of securecookies Add a script to trivialize a special form of securecookies Sep 16, 2018
@cschanaj cschanaj closed this Sep 17, 2018
@cschanaj cschanaj deleted the trivialize-special-form-securecookies-1 branch September 17, 2018 11:28
@cschanaj cschanaj restored the trivialize-special-form-securecookies-1 branch September 17, 2018 11:36
@cschanaj cschanaj reopened this Sep 17, 2018
@cschanaj cschanaj closed this Sep 17, 2018
@cschanaj cschanaj reopened this Sep 17, 2018
@cschanaj cschanaj closed this Sep 17, 2018
@cschanaj cschanaj reopened this Sep 17, 2018
@cschanaj cschanaj closed this Sep 17, 2018
@cschanaj cschanaj reopened this Sep 17, 2018
@J0WI
Copy link
Contributor

J0WI commented Sep 17, 2018

The changes LGTM.
@Hainish would you like to review the script?

@cschanaj
Copy link
Collaborator Author

cschanaj commented Sep 18, 2018

I have found another pattern which can be trivialized in a similar way, namely

<securecookie host="^(?:.*\.)?about.me$" name=".+" />

affecting 450+ rulesets. So it will be great if the script got reviewed before I proceed with further trivialization (in another PR).

P.S. for a list of affected rulesets $ git grep -lF '^(?:.*\.)?'

@cschanaj
Copy link
Collaborator Author

cschanaj commented Sep 21, 2018

@J0WI @Hainish Sorry that I have to push e55f367 to resolve the merge conflicts.

P.S. It might worth merging this asap to avoid possible merge conflicts. For #16540 (comment), if needed, I can submit another PR to change the script and let @Hainish to review it.

@cschanaj
Copy link
Collaborator Author

@Hainish would you be interested in looking at the script in this PR as well?

@Hainish
Copy link
Member

Hainish commented Sep 29, 2018

Looking good - thank you!

@Hainish Hainish merged commit 65c7e66 into EFForg:master Sep 29, 2018
@cschanaj cschanaj deleted the trivialize-special-form-securecookies-1 branch September 29, 2018 03:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants