This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Fix extension popup shows rulesets from previous pages #17025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STR:
Issues
02a9220 breaks browser test because #17010 contains a bugs. Step 3 can be repeated infinitely for different domains, as long as all the subsequent pages are HTTPS only. So this bug cannot be ignored.
For non-HTTPS pages, if
main_frame
is redirected by HTTPSE, no ruleset will be shown on the popup. Otherwise, rulesets for page's resources will be shown (if any).For HTTPS pages, no ruleset be shown unless the page serve mixedcontent
No rulesets will be shown for most of the time (at least for me), this might confuse some users that HTTPSE is not working. Perhaps there should be a brief explanation in the release notice on this matter.
To enable
test/selenium/test_popup.py::TestPopup::test_rule_shown
, we need to perform the test against amixedcontent
pages ... which seem an anti-pattern for me. So I have disabled the test in 2bf5f79, I am open for discussions on this.cc @jsha @zoracon @Hainish This PR will fix a bug from #17010 and should be merged before the next release. thanks.