Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Clean up HTTPS to HTTPS rulesets #17043

Merged
merged 7 commits into from
Nov 6, 2018

Conversation

zoracon
Copy link
Contributor

@zoracon zoracon commented Nov 5, 2018

In #16924 we fixed many rulesets that were HTTPS to HTTPS, however when we ran the RELAX NG validator, it caught a handful of rulesets that were failing regardless of them being turned off or not. This PR helps in that clean up and as well assists in helping with @Bisaloo's PR (#17012) that helped to clear out the checks in the whitelist test that checked for the HTTPS to HTTPS flag, which is not longer needed.

To be more specific, this PR mainly deleted those problematic rulesets that were default off and converted a few to trivial rulesets.

@zoracon zoracon self-assigned this Nov 5, 2018
@Hainish Hainish added the top-1k label Nov 5, 2018
@cschanaj
Copy link
Collaborator

cschanaj commented Nov 5, 2018

why simply delete those rulesets rather than updating them? there is only a handful of rulesets and making minimal changes (if we ignore the fetch test) to pass the validations test is possible.

@zoracon
Copy link
Contributor Author

zoracon commented Nov 5, 2018

why simply delete those rulesets rather than updating them? there is only a handful of rulesets and making minimal changes (if we ignore the fetch test) to pass the validations test is possible.

Many of the rulesets in this particular PR were already turned off, therefore not in use. I updated the ones that were to help pass the validations needed. Overall I wanted to get this up so this work could help #17012 out with the contribution they made as well. In #16924, many were updated to pass coverage since they were very much still on use. This PR mostly addresses the more problematic of that bunch.

@zoracon zoracon merged commit feb5c13 into EFForg:master Nov 6, 2018
This was referenced Nov 9, 2018
@zoracon zoracon deleted the whitelist-config-https-change branch May 15, 2020 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants