This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Unused rule MyComputer #19141
Merged
Unused rule MyComputer #19141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watchdog.mycomputer.com was in an unused rule.
jayvdb
force-pushed
the
unused-rule-MyComputer
branch
from
2e1ff7a to
3e709f1
Compare
|
Please remove the comment on the non-functional hosts as all the host are functional now. A trivial rule |
|
@cschanaj, thanks for taking a look. I've made the simplification enhancement to the rule, and I've used https://github.com/jonluca/Anubis and https://github.com/blark/aiodnsbrute to probe for other hosts, in order to justify not using |
jayvdb
force-pushed
the
unused-rule-MyComputer
branch
from
f3ec9a9 to
439df59
Compare
|
Thanks @pipboy96 ; found two more valid hosts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #17965 #12297
From #18938